linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Emil Goode <emilgoode@gmail.com>
Cc: Eduardo Valentin <eduardo.valentin@ti.com>,
	Zhang Rui <rui.zhang@intel.com>, Len Brown <lenb@kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] ACPI: thermal: remove const from thermal_zone_device_ops declaration
Date: Tue, 7 Jan 2014 19:34:03 -0400	[thread overview]
Message-ID: <52CC8EEB.9010604@ti.com> (raw)
In-Reply-To: <1389111895-23007-1-git-send-email-emilgoode@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]

On 07-01-2014 12:24, Emil Goode wrote:
> The following commit introduced the requirement to not declare
> thermal_zone_device_ops structs as const in order to allow
> changing the .get_temp callback.
> 
> commit 4e5e4705bf69ea450f58fc709ac5888f321a9299
> Author: Eduardo Valentin <eduardo.valentin@ti.com>
> Date:   Wed Jul 3 15:35:39 2013 -0400
> 
>     thermal: introduce device tree parser
> 
> Signed-off-by: Emil Goode <emilgoode@gmail.com>

Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>

> ---
>  drivers/acpi/thermal.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> index 1fd21ad..8349a55 100644
> --- a/drivers/acpi/thermal.c
> +++ b/drivers/acpi/thermal.c
> @@ -861,7 +861,7 @@ acpi_thermal_unbind_cooling_device(struct thermal_zone_device *thermal,
>  	return acpi_thermal_cooling_device_cb(thermal, cdev, false);
>  }
>  
> -static const struct thermal_zone_device_ops acpi_thermal_zone_ops = {
> +static struct thermal_zone_device_ops acpi_thermal_zone_ops = {
>  	.bind = acpi_thermal_bind_cooling_device,
>  	.unbind	= acpi_thermal_unbind_cooling_device,
>  	.get_temp = thermal_get_temp,
> 


-- 
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]

  reply	other threads:[~2014-01-07 23:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07 16:24 [PATCH] ACPI: thermal: remove const from thermal_zone_device_ops declaration Emil Goode
2014-01-07 23:34 ` Eduardo Valentin [this message]
2014-01-08 23:07   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CC8EEB.9010604@ti.com \
    --to=eduardo.valentin@ti.com \
    --cc=emilgoode@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).