From: "H. Peter Anvin" <hpa@zytor.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
"David E. Box" <david.e.box@linux.intel.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
mjg59@srcf.ucam.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v6][RESEND] platform: x86: New BayTrail IOSF-SB MBI driver
Date: Tue, 07 Jan 2014 16:00:32 -0800 [thread overview]
Message-ID: <52CC9520.4060208@zytor.com> (raw)
In-Reply-To: <3119193.jBSlNlK309@vostro.rjw.lan>
On 01/07/2014 04:11 PM, Rafael J. Wysocki wrote:
>>
>> Ok, I spoke with other developers and I apparently misunderstood the context
>> here. Distro's enable these features and this is too detailed for them to know
>> what to do with it. How about simply "Required to enable platform specific power
>> managemnet features on Baytrail"?
>>
>> KISS is easier said than done.
>
> Well, I personally think that this code should go into arch/x86/ as library code
> needed to access IOSF Sideband on some platforms. I probably would make modules
> depending on it select it, so for example if the RAPL driver is going to be
> built, your driver should be build either and rather unconditionally in that
> case.
>
> So the rule should be "if something *may* need it, build it" in my opinion.
>
I thought we were targeting this for drivers/x86? However, perhaps with
power management tied in that doesn't make too much sense.
-hpa
next prev parent reply other threads:[~2014-01-08 0:01 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 6:05 [PATCH 1/2] New Driver for IOSF-SB MBI access on Intel SOCs David E. Box
2013-11-22 6:05 ` [PATCH 2/2] ACPI / platform: Add ACPI ID for Intel IOSF-SB David E. Box
2013-11-22 18:18 ` [PATCH 1/2] New Driver for IOSF-SB MBI access on Intel SOCs Matthew Garrett
2013-11-24 0:41 ` One Thousand Gnomes
2013-12-03 23:59 ` [PATCHv2 0/2] New driver for Intel IOSF MBI access David E. Box
2013-12-03 23:59 ` [PATCHv2 1/2] New Driver for IOSF-SB MBI access on Intel SOCs David E. Box
2013-12-04 6:44 ` Andi Kleen
2013-12-03 23:59 ` [PATCHv2 2/2] ACPI/platform: Add ACPI ID for Intel MBI device David E. Box
2013-12-04 1:30 ` Matthew Garrett
2013-12-04 2:17 ` David E. Box
2013-12-04 2:21 ` Matthew Garrett
2013-12-04 2:44 ` David E. Box
2013-12-04 2:54 ` Matthew Garrett
2013-12-04 21:34 ` Rafael J. Wysocki
2013-12-05 20:01 ` [PATCH] X86 platform: New IOSF-SB MBI driver for Intel SOCs David E. Box
2013-12-05 22:32 ` Rafael J. Wysocki
2013-12-06 20:59 ` [PATCH] X86 platform: New BayTrail IOSF-SB MBI driver David E. Box
2013-12-07 1:29 ` Rafael J. Wysocki
2013-12-10 1:11 ` David E. Box
2013-12-19 22:37 ` [PATCH v5][RESEND] " David E. Box
2013-12-20 1:59 ` Rafael J. Wysocki
2013-12-20 7:01 ` David E. Box
2013-12-30 18:12 ` [PATCH v6] " David E. Box
2014-01-07 18:03 ` [PATCH v6][RESEND] platform: x86: " David E. Box
2014-01-07 18:15 ` Randy Dunlap
2014-01-07 18:48 ` David E. Box
2014-01-07 19:30 ` Randy Dunlap
2014-01-07 20:46 ` Rafael J. Wysocki
2014-01-07 21:43 ` David E. Box
2014-01-08 0:11 ` Rafael J. Wysocki
2014-01-08 0:00 ` H. Peter Anvin [this message]
2014-01-08 5:27 ` David E. Box
2014-01-08 13:47 ` Rafael J. Wysocki
2014-01-08 21:27 ` [PATCH v7] arch: x86: New MailBox support driver for Intel SOC's David E. Box
2014-01-10 22:10 ` [tip:x86/platform] " tip-bot for David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CC9520.4060208@zytor.com \
--to=hpa@zytor.com \
--cc=david.e.box@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).