Re: OMAPDSS: DISPC: horizontal timing too tight errors

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]

On 2014-01-07 22:25, Ivaylo Dimitrov wrote:

>>> Besides compiling DSS driver with DEBUG enabled and providing the log
>>> (yeah, I know I should've done it already and have the logs included in
>>> this mail, but... :) ), is there anything else I can do to find the
>>> culprit for those errors.
>>
>> You could look at the original patch in the Nokia kernel to see if the
>> mainline version is ok. Or maybe even better, try the same use case on
>> Nokia's kernel to see if it works.
>>
>>   Tomi
>>
>>
> 
> Ok, after looking at what both N900 and N9 Nokia kernels do, I came up
> with the patch bellow. If you are ok with the changes, I'll submit the
> patch as it should. With that patch I tried more than 20 videos of
> different resolutions(including 720p), not a single failure :) .
> Basically it changes the core clock calculation to be done in the same
> way as in the Nokia kernels.

Hmm ok. So the code was only partially ported to mainline?

You only seem to touch omap3 specific funcs, so I guess it's safe to
presume omap2/omap4+ work as well (or bad) as without this patch (i.e.
no need to test on various omaps =).

Thanks for figuring this out. Please send a proper patch, and if
possible, with an url to the Nokia kernel's code (presuming it's
available in a sane way).

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]