From: Randy Dunlap <rdunlap@infradead.org>
To: Laszlo Papp <lpapp@kde.org>, Mark Brown <broonie@kernel.org>
Cc: linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] include/linux/regmap.h: fix a couple of typos
Date: Wed, 08 Jan 2014 18:43:20 -0800 [thread overview]
Message-ID: <52CE0CC8.20500@infradead.org> (raw)
In-Reply-To: <CAOMwXhNsuG-s7z2xfZK9-qGPWNoyuE_1x3pSmz6CC2qyiituLA@mail.gmail.com>
On 01/08/14 17:46, Laszlo Papp wrote:
> On Wed, Jan 8, 2014 at 9:49 PM, Mark Brown <broonie@kernel.org> wrote:
>> On Wed, Jan 08, 2014 at 09:08:44PM +0000, Laszlo Papp wrote:
>>> On Wed, Jan 8, 2014 at 9:02 PM, Laszlo Papp <lpapp@kde.org> wrote:
>>
>>>> That being said, I will not have time, nor the motivation to argue
>>>> over such a nuance, so feel free to reject the change.
>>
>>> Of course, this is just on top of the vim spell checker error as I
>>> wrote in the commit message...
>>
>>> Oh yes, and one more factual data in here:
>>
>>> lpapp ~/Projects/linux-staging $ grep -rn "e\.g\." . | wc -l
>>> 3447
>>
>>> lpapp ~/Projects/linux-staging $ grep -rn " eg," | wc -l
>>> 18
>>
>> That's not the issue - it's dropping the comma. It's either "e.g." or
>> "eg", the comma is a separate thing providing a break between clauses.
>> Strictly it should have the periods since it is an abbreviation but
>> their use is more vauge in fixed point text since they look ugly, the
>> thing that made me complain was that you dropped the comma as well as
>> substituting in the expanded version.
>
> I still do not get what point you are trying to make. Could you please
> provide evidence? Because really, this is the usage I have seen in
> projects out there all around, including the majority of the linux
> kernel.
>
> Here is some more data:
>
> grep -rn "e\.g\. " . | wc -l
> 2553
> lpapp ~/Projects/linux-staging $ grep -rn "e\.g\.," . | wc -l
> 573
> --
Hi,
I am used to seeing e.g. and i.e. always followed by a comma when they are
used to begin a sentence. However, I just checked and some online style
guides say to omit the comma and some say to use it, and we (Linux kernel)
don't really have a writing style guide to look at. I think that makes it
up to the maintainer to decide what is acceptable.
--
~Randy
next prev parent reply other threads:[~2014-01-09 2:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 17:22 [PATCH] include/linux/regmap.h: fix a couple of typos Laszlo Papp
2014-01-08 18:07 ` Mark Brown
2014-01-08 18:59 ` Laszlo Papp
2014-01-08 19:07 ` Mark Brown
2014-01-08 21:02 ` Laszlo Papp
2014-01-08 21:08 ` Laszlo Papp
2014-01-08 21:49 ` Mark Brown
2014-01-09 1:46 ` Laszlo Papp
2014-01-09 2:43 ` Randy Dunlap [this message]
2014-01-09 10:22 ` Laszlo Papp
2014-01-09 12:23 ` Mark Brown
2014-01-09 11:18 ` Mark Brown
2014-01-08 22:04 ` Randy Dunlap
2014-01-08 19:07 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CE0CC8.20500@infradead.org \
--to=rdunlap@infradead.org \
--cc=broonie@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpapp@kde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox