From: Ian Abbott <abbotti@mev.co.uk>
To: Michal Kwiatkowski <michaelflowersky@geekingspree.com>,
Ian Abbott <ian.abbott@mev.co.uk>
Cc: "hsweeten@visionengravers.com" <hsweeten@visionengravers.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: comedi: amcc_s5933: "no space before tabs" coding style fixes.
Date: Fri, 10 Jan 2014 10:33:29 +0000 [thread overview]
Message-ID: <52CFCC79.5050307@mev.co.uk> (raw)
In-Reply-To: <1389308335-6724-1-git-send-email-michaelflowersky@geekingspree.com>
On 2014-01-09 22:58, Michal Kwiatkowski wrote:
> Fixed a coding style issues.
>
> Signed-off-by: Michal Kwiatkowski <michaelflowersky@geekingspree.com>
> ---
> drivers/staging/comedi/drivers/amcc_s5933.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/amcc_s5933.h b/drivers/staging/comedi/drivers/amcc_s5933.h
> index b810d5f..2ba7364 100644
> --- a/drivers/staging/comedi/drivers/amcc_s5933.h
> +++ b/drivers/staging/comedi/drivers/amcc_s5933.h
> @@ -145,12 +145,12 @@
> #define AINT_READ_COMPL 0x00008000
> #define AINT_WRITE_COMPL 0x00004000
>
> -#define AINT_OMB_ENABLE 0x00001000
> -#define AINT_OMB_SELECT 0x00000c00
> +#define AINT_OMB_ENABLE 0x00001000
> +#define AINT_OMB_SELECT 0x00000c00
> #define AINT_OMB_BYTE 0x00000300
>
> -#define AINT_IMB_ENABLE 0x00000010
> -#define AINT_IMB_SELECT 0x0000000c
> +#define AINT_IMB_ENABLE 0x00000010
> +#define AINT_IMB_SELECT 0x0000000c
> #define AINT_IMB_BYTE 0x00000003
>
> /* these are bits from various different registers, needs cleanup XXX */
>
Harmless. (Good!)
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
prev parent reply other threads:[~2014-01-10 10:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 22:58 [PATCH] Staging: comedi: amcc_s5933: "no space before tabs" coding style fixes Michal Kwiatkowski
2014-01-10 10:33 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CFCC79.5050307@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=michaelflowersky@geekingspree.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox