From: Arjan van de Ven <arjan@linux.intel.com>
To: Dave Young <dyoung@redhat.com>, Borislav Petkov <bp@alien8.de>
Cc: Linux EFI <linux-efi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@suse.de>,
Matt Fleming <matt@console-pimps.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
"H. Peter Anvin" <hpa@zytor.com>, Toshi Kani <toshi.kani@hp.com>
Subject: Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an arbitrary pagetable
Date: Mon, 13 Jan 2014 06:48:10 -0800 [thread overview]
Message-ID: <52D3FCAA.7070004@linux.intel.com> (raw)
In-Reply-To: <20140113122320.GA1900@darkstar.nay.redhat.com>
On 1/13/2014 4:23 AM, Dave Young wrote:
>>
>>> How about do not limit to only if (pgd) case, instead do something
>>> like below: set dump_to_dmesg as a module parameter
>>
>> X86_PTDUMP is not a module.
>
> Hmm, I just see the module macros in the code, since it's a bool Kconfig
> I think the dump_pagetables.c need a cleanup,
> remove the #include <linux/module.h> and below lines:
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Arjan van de Ven <arjan@linux.intel.com>");
> MODULE_DESCRIPTION("Kernel debugging helper that dumps pagetables");
personally I consider it good form to always have this kind of information in .c files,
regardless of the KConfig side of thing...
next prev parent reply other threads:[~2014-01-13 14:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 20:49 [PATCH 0/4] EFI memmap fix v2 Borislav Petkov
2014-01-11 20:49 ` [PATCH 1/4] x86, ptdump: Add the functionality to dump an arbitrary pagetable Borislav Petkov
2014-01-11 20:59 ` Joe Perches
2014-01-13 5:32 ` Dave Young
2014-01-13 10:18 ` Borislav Petkov
2014-01-13 12:23 ` Dave Young
2014-01-13 14:48 ` Arjan van de Ven [this message]
2014-01-13 14:57 ` Borislav Petkov
2014-01-14 1:40 ` Dave Young
2014-01-14 18:18 ` H. Peter Anvin
2014-01-15 1:16 ` Dave Young
2014-01-15 14:11 ` H. Peter Anvin
2014-01-16 1:44 ` Dave Young
2014-01-16 2:41 ` Arjan van de Ven
2014-01-16 3:03 ` Dave Young
2014-01-16 4:04 ` H. Peter Anvin
2014-01-16 6:46 ` Dave Young
2014-01-16 6:54 ` Dave Young
2014-01-16 14:52 ` Arjan van de Ven
2014-01-13 15:49 ` Matt Fleming
2014-01-11 20:49 ` [PATCH 2/4] efi: Dump the EFI page table Borislav Petkov
2014-01-13 16:00 ` Matt Fleming
2014-01-14 1:36 ` Dave Young
2014-01-11 20:49 ` [PATCH 3/4] x86, pageattr: Export page unmapping interface Borislav Petkov
2014-01-11 20:49 ` [PATCH 4/4] efi: Make efi virtual runtime map passing more robust Borislav Petkov
2014-01-13 5:40 ` Dave Young
2014-01-13 10:27 ` Borislav Petkov
2014-01-13 13:17 ` Dave Young
2014-01-13 16:22 ` [PATCH 0/4] EFI memmap fix v2 Toshi Kani
2014-01-13 16:54 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D3FCAA.7070004@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mjg59@srcf.ucam.org \
--cc=toshi.kani@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).