From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751713AbaANQ5O (ORCPT ); Tue, 14 Jan 2014 11:57:14 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:47640 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751375AbaANQ5L (ORCPT ); Tue, 14 Jan 2014 11:57:11 -0500 Message-ID: <52D56C3A.7000704@ti.com> Date: Tue, 14 Jan 2014 10:56:26 -0600 From: "Anna, Suman" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: CC: Ohad Ben-Cohen , Mark Rutland , Tony Lindgren , Kumar Gala , , , , Subject: Re: [PATCHv4 6/7] hwspinlock/omap: enable module before reading SYSSTATUS register References: <1389658764-39199-1-git-send-email-s-anna@ti.com> <1389658764-39199-7-git-send-email-s-anna@ti.com> <20140114131052.GA10818@saruman.home> <20140114140440.GA15785@saruman.home> In-Reply-To: <20140114140440.GA15785@saruman.home> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Felipe, On 01/14/2014 08:04 AM, Felipe Balbi wrote: > Hi again, > > On Tue, Jan 14, 2014 at 07:10:52AM -0600, Felipe Balbi wrote: >>> diff --git a/drivers/hwspinlock/omap_hwspinlock.c b/drivers/hwspinlock/omap_hwspinlock.c >>> index 9f56fb2..194886e 100644 >>> --- a/drivers/hwspinlock/omap_hwspinlock.c >>> +++ b/drivers/hwspinlock/omap_hwspinlock.c >>> @@ -101,10 +101,23 @@ static int omap_hwspinlock_probe(struct platform_device *pdev) >>> if (!io_base) >>> return -ENOMEM; >>> >>> + /* >>> + * make sure the module is enabled and clocked before reading >>> + * the module SYSSTATUS register >>> + */ >>> + pm_runtime_enable(&pdev->dev); >>> + pm_runtime_get_sync(&pdev->dev); > > another thing, you need to check return of pm_runtime_get_sync() OK, let me check this and your other comment, and the fix is probably a separate patch. regards Suman