public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: joeyli <jlee@suse.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Toshi Kani <toshi.kani@hp.com>
Cc: Matt Fleming <matt@console-pimps.org>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Matthew Garrett <matthew.garrett@nebula.com>,
	Elliott@hp.com, samer.el-haj-mahmoud@hp.com,
	Oliver Neukum <oneukum@suse.de>,
	werner@suse.com, trenn@suse.de, JBeulich@suse.com,
	linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
	x86@kernel.org,
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	linux-acpi@vger.kernel.org, Borislav Petkov <bp@suse.de>
Subject: Re: [RFT][PATCH] ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode()
Date: Tue, 14 Jan 2014 10:00:52 -0800	[thread overview]
Message-ID: <52D57B54.7080509@zytor.com> (raw)
In-Reply-To: <1389672548.24105.252.camel@linux-s257.site>

On 01/13/2014 08:09 PM, joeyli wrote:
> 
> This patch works to me on Acer Gateway Z5WT2 UEFI notebook and Intel
> UEFI development board.
> 
> Does it possible move acpi_early_init() to before timekeeping_init()?
> The position is also before efi_enter_virtual_mode() and that will be
> useful for parsing ACPI TAD to set system clock:
> 
> diff --git a/init/main.c b/init/main.c
> index febc511..b6d93c8 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -565,6 +565,7 @@ asmlinkage void __init start_kernel(void)
>         init_timers();
>         hrtimers_init();
>         softirq_init();
> +       acpi_early_init();
>         timekeeping_init();
>         time_init();
>         sched_clock_postinit();
> @@ -641,7 +642,6 @@ asmlinkage void __init start_kernel(void)
>  
>         check_bugs();
>  
> -       acpi_early_init(); /* before LAPIC and SMP init */
>         sfi_init_late();
>  
>         if (efi_enabled(EFI_RUNTIME_SERVICES)) {
> 

Hi Toshi,

Could you try this variant, too?  If this works as well then we end up
solving two problems in one patch...

	-hpa




  parent reply	other threads:[~2014-01-14 18:01 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19  7:43 [RFC PATCH 00/14] Support timezone of ACPI TAD and EFI TIME Lee, Chun-Yi
2013-12-19  7:44 ` [PATCH 01/14] rtc-efi: fix decrease day twice when computing year days Lee, Chun-Yi
2013-12-19  7:44 ` [PATCH 03/14] rtc: block registration of rtc-cmos when CMOS RTC Not Present Lee, Chun-Yi
2013-12-19 14:38   ` H. Peter Anvin
2013-12-20  3:54     ` joeyli
2013-12-20  4:20       ` H. Peter Anvin
2013-12-19 14:59 ` [RFC PATCH 00/14] Support timezone of ACPI TAD and EFI TIME H. Peter Anvin
2013-12-19 16:04   ` Alessandro Zummo
2013-12-20  4:05   ` joeyli
2013-12-20  4:22     ` H. Peter Anvin
2013-12-20  5:38       ` joeyli
2013-12-20 21:10         ` H. Peter Anvin
2013-12-20 21:25           ` H. Peter Anvin
2013-12-20 21:45           ` Rafael J. Wysocki
2013-12-20 21:43             ` H. Peter Anvin
2013-12-20 21:50               ` Matt Fleming
2013-12-20 22:18                 ` Rafael J. Wysocki
2013-12-21 12:21                   ` Matt Fleming
2014-01-12  0:30                     ` [RFT][PATCH] ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode() (was: Re: [RFC PATCH 00/14] Support timezone of ACPI TAD and EFI TIME) Rafael J. Wysocki
2014-01-12  9:06                       ` Borislav Petkov
2014-01-14  2:04                         ` Toshi Kani
2014-01-14 16:25                           ` Toshi Kani
2014-01-12 11:05                       ` Matt Fleming
2014-01-17 12:20                         ` Matt Fleming
2014-01-14  4:09                       ` joeyli
2014-01-14 16:50                         ` Rafael J. Wysocki
2014-01-14 18:00                         ` H. Peter Anvin [this message]
2014-01-14 20:32                           ` [RFT][PATCH] ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode() Toshi Kani
2014-01-15  7:18                             ` joeyli
2013-12-21  2:43             ` [RFC PATCH 00/14] Support timezone of ACPI TAD and EFI TIME joeyli
2013-12-20 10:53       ` Thomas Renninger
2013-12-20 22:15         ` H. Peter Anvin
2013-12-20 15:16       ` Matthew Garrett
2013-12-20 16:57         ` H. Peter Anvin
2013-12-20 16:58           ` Matthew Garrett
2013-12-20 20:29             ` H. Peter Anvin
2013-12-20 20:32               ` Matthew Garrett
2013-12-20 21:14                 ` H. Peter Anvin
2013-12-20 21:12         ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52D57B54.7080509@zytor.com \
    --to=hpa@zytor.com \
    --cc=Elliott@hp.com \
    --cc=JBeulich@suse.com \
    --cc=a.zummo@towertech.it \
    --cc=bp@suse.de \
    --cc=jlee@suse.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@console-pimps.org \
    --cc=matthew.garrett@nebula.com \
    --cc=oneukum@suse.de \
    --cc=rjw@rjwysocki.net \
    --cc=rtc-linux@googlegroups.com \
    --cc=samer.el-haj-mahmoud@hp.com \
    --cc=toshi.kani@hp.com \
    --cc=trenn@suse.de \
    --cc=werner@suse.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox