From: John Stultz <john.stultz@linaro.org>
To: mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, peterz@infradead.org,
sboyd@codeaurora.org, w@1wt.eu, khalasa@piap.pl,
u.kleine-koenig@pengutronix.de, tglx@linutronix.de,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:core/urgent] sched_clock: Disable seqlock lockdep usage in sched_clock()
Date: Tue, 14 Jan 2014 11:18:23 -0800 [thread overview]
Message-ID: <52D58D7F.2030306@linaro.org> (raw)
In-Reply-To: <tip-7a06c41cbec33c6dbe7eec575c61986122617408@git.kernel.org>
On 01/12/2014 10:42 AM, tip-bot for John Stultz wrote:
> Commit-ID: 7a06c41cbec33c6dbe7eec575c61986122617408
> Gitweb: http://git.kernel.org/tip/7a06c41cbec33c6dbe7eec575c61986122617408
> Author: John Stultz <john.stultz@linaro.org>
> AuthorDate: Thu, 2 Jan 2014 15:11:14 -0800
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Sun, 12 Jan 2014 10:14:00 +0100
>
> sched_clock: Disable seqlock lockdep usage in sched_clock()
>
> Unfortunately the seqlock lockdep enablement can't be used
> in sched_clock(), since the lockdep infrastructure eventually
> calls into sched_clock(), which causes a deadlock.
>
> Thus, this patch changes all generic sched_clock() usage
> to use the raw_* methods.
>
> Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
> Reported-by: Krzysztof Hałasa <khalasa@piap.pl>
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Willy Tarreau <w@1wt.eu>
> Signed-off-by: Peter Zijlstra <peterz@infradead.org>
> Link: http://lkml.kernel.org/r/1388704274-5278-2-git-send-email-john.stultz@linaro.org
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
Hey Ingo,
Just wanted to follow up here, since I've still not seen this (and
the raw_ renaming patch) submitted to Linus. These address a lockup that
triggers on ARM systems if lockdep is enabled and it would be good to
get it in before 3.13 is out.
thanks
-john
next prev parent reply other threads:[~2014-01-14 19:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-31 10:37 v3.13-rc6+ regression (ARM board) Krzysztof Hałasa
2013-12-31 10:45 ` Willy Tarreau
2014-01-02 10:02 ` Krzysztof Hałasa
2014-01-02 10:14 ` Uwe Kleine-König
2014-01-02 12:07 ` Krzysztof Hałasa
2014-01-02 19:38 ` Linus Torvalds
2014-01-02 20:03 ` John Stultz
2014-01-02 20:30 ` John Stultz
2014-01-02 20:42 ` Stephen Boyd
2014-01-02 20:52 ` John Stultz
2014-01-02 20:43 ` Linus Torvalds
2014-01-02 21:34 ` John Stultz
2014-01-02 21:54 ` [PATCH] sched_clock: Disable seqlock lockdep usage in sched_clock John Stultz
2014-01-02 22:15 ` Linus Torvalds
2014-01-02 22:21 ` John Stultz
2014-01-02 23:11 ` [PATCH 1/2] seqlock: Use raw_ prefix instead of _no_lockdep John Stultz
2014-01-02 23:11 ` [PATCH 2/2] sched_clock: Disable seqlock lockdep usage in sched_clock John Stultz
2014-01-03 0:46 ` Stephen Boyd
2014-01-03 6:05 ` Krzysztof Hałasa
2014-01-12 18:42 ` [tip:core/urgent] sched_clock: Disable seqlock lockdep usage in sched_clock() tip-bot for John Stultz
2014-01-14 19:18 ` John Stultz [this message]
2014-01-15 6:38 ` Ingo Molnar
2014-01-03 0:46 ` [PATCH 1/2] seqlock: Use raw_ prefix instead of _no_lockdep Stephen Boyd
2014-01-03 0:50 ` Linus Torvalds
2014-01-04 0:28 ` John Stultz
2014-01-06 10:10 ` Peter Zijlstra
2014-01-12 18:42 ` [tip:core/urgent] " tip-bot for John Stultz
2014-01-03 6:01 ` v3.13-rc6+ regression (ARM board) Krzysztof Hałasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D58D7F.2030306@linaro.org \
--to=john.stultz@linaro.org \
--cc=hpa@zytor.com \
--cc=khalasa@piap.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=sboyd@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox