[PATCH] Documentation / CPU hotplug: Fix the typo in example code

[PATCH] Documentation / CPU hotplug: Fix the typo in example code

[Sangjung Woo]

As the notifier_block name (i.e. foobar_cpu_notifer) is different from
the parameter (i.e.foobar_cpu_notifier) of register function, that is
definitely error and it also makes readers confused.

Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
---
 Documentation/cpu-hotplug.txt |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/cpu-hotplug.txt b/Documentation/cpu-hotplug.txt
index 8cb9938..be675d2 100644
--- a/Documentation/cpu-hotplug.txt
+++ b/Documentation/cpu-hotplug.txt
@@ -285,7 +285,7 @@ A: This is what you would need in your kernel code to receive notifications.
 		return NOTIFY_OK;
 	}
 
-	static struct notifier_block foobar_cpu_notifer =
+	static struct notifier_block foobar_cpu_notifier =
 	{
 	   .notifier_call = foobar_cpu_callback,
 	};
-- 
1.7.9.5

Re: [PATCH] Documentation / CPU hotplug: Fix the typo in example code

[Srivatsa S. Bhat]

On 01/15/2014 10:40 AM, Sangjung Woo wrote:
> As the notifier_block name (i.e. foobar_cpu_notifer) is different from
> the parameter (i.e.foobar_cpu_notifier) of register function, that is
> definitely error and it also makes readers confused.
> 
> Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>

Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>

Regards,
Srivatsa S. Bhat

> ---
>  Documentation/cpu-hotplug.txt |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/cpu-hotplug.txt b/Documentation/cpu-hotplug.txt
> index 8cb9938..be675d2 100644
> --- a/Documentation/cpu-hotplug.txt
> +++ b/Documentation/cpu-hotplug.txt
> @@ -285,7 +285,7 @@ A: This is what you would need in your kernel code to receive notifications.
>  		return NOTIFY_OK;
>  	}
> 
> -	static struct notifier_block foobar_cpu_notifer =
> +	static struct notifier_block foobar_cpu_notifier =
>  	{
>  	   .notifier_call = foobar_cpu_callback,
>  	};
> 

Re: [PATCH] Documentation / CPU hotplug: Fix the typo in example code

[Andrew Morton]

On Wed, 15 Jan 2014 14:10:26 +0900 Sangjung Woo <sangjung.woo@samsung.com> wrote:

> As the notifier_block name (i.e. foobar_cpu_notifer) is different from
> the parameter (i.e.foobar_cpu_notifier) of register function, that is
> definitely error and it also makes readers confused.
> 

btw, that document doesn't mention hotcpu_notifier(), which is actually
the preferred means of registration.  Because it causes all the hotplug
code to be elided when CONFIG_HOTPLUG_CPU=n, without using ifdefs.