* [PATCH] Documentation / CPU hotplug: Fix the typo in example code
@ 2014-01-15 5:10 Sangjung Woo
2014-01-15 5:45 ` Srivatsa S. Bhat
2014-01-15 23:33 ` Andrew Morton
0 siblings, 2 replies; 3+ messages in thread
From: Sangjung Woo @ 2014-01-15 5:10 UTC (permalink / raw)
To: Andrew Morton, Rob Landley, linux-doc, linux-kernel
Cc: Rafael J. Wysocki, Sangjung Woo
As the notifier_block name (i.e. foobar_cpu_notifer) is different from
the parameter (i.e.foobar_cpu_notifier) of register function, that is
definitely error and it also makes readers confused.
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
---
Documentation/cpu-hotplug.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/cpu-hotplug.txt b/Documentation/cpu-hotplug.txt
index 8cb9938..be675d2 100644
--- a/Documentation/cpu-hotplug.txt
+++ b/Documentation/cpu-hotplug.txt
@@ -285,7 +285,7 @@ A: This is what you would need in your kernel code to receive notifications.
return NOTIFY_OK;
}
- static struct notifier_block foobar_cpu_notifer =
+ static struct notifier_block foobar_cpu_notifier =
{
.notifier_call = foobar_cpu_callback,
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Documentation / CPU hotplug: Fix the typo in example code
2014-01-15 5:10 [PATCH] Documentation / CPU hotplug: Fix the typo in example code Sangjung Woo
@ 2014-01-15 5:45 ` Srivatsa S. Bhat
2014-01-15 23:33 ` Andrew Morton
1 sibling, 0 replies; 3+ messages in thread
From: Srivatsa S. Bhat @ 2014-01-15 5:45 UTC (permalink / raw)
To: Sangjung Woo
Cc: Andrew Morton, Rob Landley, linux-doc, linux-kernel,
Rafael J. Wysocki
On 01/15/2014 10:40 AM, Sangjung Woo wrote:
> As the notifier_block name (i.e. foobar_cpu_notifer) is different from
> the parameter (i.e.foobar_cpu_notifier) of register function, that is
> definitely error and it also makes readers confused.
>
> Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Regards,
Srivatsa S. Bhat
> ---
> Documentation/cpu-hotplug.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/cpu-hotplug.txt b/Documentation/cpu-hotplug.txt
> index 8cb9938..be675d2 100644
> --- a/Documentation/cpu-hotplug.txt
> +++ b/Documentation/cpu-hotplug.txt
> @@ -285,7 +285,7 @@ A: This is what you would need in your kernel code to receive notifications.
> return NOTIFY_OK;
> }
>
> - static struct notifier_block foobar_cpu_notifer =
> + static struct notifier_block foobar_cpu_notifier =
> {
> .notifier_call = foobar_cpu_callback,
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Documentation / CPU hotplug: Fix the typo in example code
2014-01-15 5:10 [PATCH] Documentation / CPU hotplug: Fix the typo in example code Sangjung Woo
2014-01-15 5:45 ` Srivatsa S. Bhat
@ 2014-01-15 23:33 ` Andrew Morton
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2014-01-15 23:33 UTC (permalink / raw)
To: Sangjung Woo; +Cc: Rob Landley, linux-doc, linux-kernel, Rafael J. Wysocki
On Wed, 15 Jan 2014 14:10:26 +0900 Sangjung Woo <sangjung.woo@samsung.com> wrote:
> As the notifier_block name (i.e. foobar_cpu_notifer) is different from
> the parameter (i.e.foobar_cpu_notifier) of register function, that is
> definitely error and it also makes readers confused.
>
btw, that document doesn't mention hotcpu_notifier(), which is actually
the preferred means of registration. Because it causes all the hotplug
code to be elided when CONFIG_HOTPLUG_CPU=n, without using ifdefs.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-15 23:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-15 5:10 [PATCH] Documentation / CPU hotplug: Fix the typo in example code Sangjung Woo
2014-01-15 5:45 ` Srivatsa S. Bhat
2014-01-15 23:33 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox