* [PATCH] net: davinci_mdio: Fix sparse warning
@ 2014-01-16 6:05 Prabhakar Lad
2014-01-16 6:14 ` Mugunthan V N
2014-01-17 1:30 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Prabhakar Lad @ 2014-01-16 6:05 UTC (permalink / raw)
To: David S. Miller, netdev; +Cc: linux-kernel, Mugunthan V N, Lad, Prabhakar
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
This patch fixes following sparse warning
davinci_mdio.c:85:27: warning: symbol 'default_pdata' was not declared. Should it be static?
Also makes the default_pdata as a constant.
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
drivers/net/ethernet/ti/davinci_mdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
index 4ec9265..0cca9de 100644
--- a/drivers/net/ethernet/ti/davinci_mdio.c
+++ b/drivers/net/ethernet/ti/davinci_mdio.c
@@ -82,7 +82,7 @@ struct davinci_mdio_regs {
} user[0];
};
-struct mdio_platform_data default_pdata = {
+static const struct mdio_platform_data default_pdata = {
.bus_freq = DEF_OUT_FREQ,
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: davinci_mdio: Fix sparse warning
2014-01-16 6:05 [PATCH] net: davinci_mdio: Fix sparse warning Prabhakar Lad
@ 2014-01-16 6:14 ` Mugunthan V N
2014-01-17 1:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Mugunthan V N @ 2014-01-16 6:14 UTC (permalink / raw)
To: Prabhakar Lad, David S. Miller, netdev; +Cc: linux-kernel
On Thursday 16 January 2014 11:35 AM, Prabhakar Lad wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> This patch fixes following sparse warning
> davinci_mdio.c:85:27: warning: symbol 'default_pdata' was not declared. Should it be static?
> Also makes the default_pdata as a constant.
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: davinci_mdio: Fix sparse warning
2014-01-16 6:05 [PATCH] net: davinci_mdio: Fix sparse warning Prabhakar Lad
2014-01-16 6:14 ` Mugunthan V N
@ 2014-01-17 1:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-01-17 1:30 UTC (permalink / raw)
To: prabhakar.csengg; +Cc: netdev, linux-kernel, mugunthanvnm
From: Prabhakar Lad <prabhakar.csengg@gmail.com>
Date: Thu, 16 Jan 2014 11:35:41 +0530
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> This patch fixes following sparse warning
> davinci_mdio.c:85:27: warning: symbol 'default_pdata' was not declared. Should it be static?
> Also makes the default_pdata as a constant.
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-17 1:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-16 6:05 [PATCH] net: davinci_mdio: Fix sparse warning Prabhakar Lad
2014-01-16 6:14 ` Mugunthan V N
2014-01-17 1:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox