From: "H. Peter Anvin" <hpa@linux.intel.com>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/apic] x86, apic: Make disabled_cpu_apicid static read_mostly, fix typos
Date: Wed, 15 Jan 2014 22:24:54 -0800 [thread overview]
Message-ID: <52D77B36.1040506@linux.intel.com> (raw)
In-Reply-To: <52D77A49.5060905@jp.fujitsu.com>
On 01/15/2014 10:20 PM, HATAYAMA Daisuke wrote:
> (2014/01/16 14:53), H. Peter Anvin wrote:
>> On 01/15/2014 08:44 PM, HATAYAMA Daisuke wrote:
>>>
>>> This is not typo in my intention.
>>>
>>> generic_processor_info() has two more cases where it ignores cpus.
>>> In either cases, printed messages are tagged with "ACPI" because this
>>> function is called when parsing ACPI MADT table in acpi_boot_init();
>>> this function is also being used to parse other kind of tables but
>>> the "ACPI" tag would mean that the function was first for ACPI only.
>>>
>>
>> But it has nothing to do with ACPI -- it is an APIC ID from the command
>> line -- so that would be actively misleading.
>>
>> -hpa
>>
>
> I never disagree to the fix itself. I wanted to explain why I wrote so.
>
> I thought it was better to unify tags in the same function because they
> should bleong to the same component, here I mean ACPI, but it's better
> to avoid the confusion, which is bigger impact.
>
Indeed. All good now.
-hpa
prev parent reply other threads:[~2014-01-16 6:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 6:44 [RESEND PATCH v10] x86, apic, kexec, Documentation: Add disable_cpu_apicid kernel parameter HATAYAMA Daisuke
2014-01-15 17:05 ` Vivek Goyal
2014-01-15 17:26 ` H. Peter Anvin
2014-01-15 17:47 ` Vivek Goyal
2014-01-15 17:54 ` H. Peter Anvin
2014-01-15 18:14 ` Vivek Goyal
2014-01-15 18:20 ` H. Peter Anvin
2014-02-10 17:28 ` Petr Tesarik
2014-01-15 17:57 ` [tip:x86/apic] x86, apic, kexec: " tip-bot for HATAYAMA Daisuke
2014-01-15 18:25 ` Ingo Molnar
2014-01-15 21:09 ` [tip:x86/apic] x86, apic: Make disabled_cpu_apicid static read_mostly, fix typos tip-bot for H. Peter Anvin
2014-01-16 4:44 ` HATAYAMA Daisuke
2014-01-16 5:53 ` H. Peter Anvin
2014-01-16 6:20 ` HATAYAMA Daisuke
2014-01-16 6:24 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D77B36.1040506@linux.intel.com \
--to=hpa@linux.intel.com \
--cc=d.hatayama@jp.fujitsu.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox