From: Levente Kurusa <levex@linux.com>
To: "Michał Kwiatkowski" <michaelflowersky@geekingspree.com>,
gregkh@linuxfoundation.org, john.stultz@linaro.org,
dan.carpenter@oracle.com, cruzjbishop@gmail.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c
Date: Thu, 16 Jan 2014 18:51:05 +0100 [thread overview]
Message-ID: <52D81C09.10901@linux.com> (raw)
In-Reply-To: <1389828756-9397-1-git-send-email-michaelflowersky@geekingspree.com>
Hello,
On 01/16/2014 12:32 AM, Michał Kwiatkowski wrote:
> This is a patch to the alarm-dev.c file that removes parentheses which
> should not appear in return statement. This error was found by the
> checkpatch.pl tool.
>
> Signed-off-by: Michał Kwiatkowski <michaelflowersky@geekingspree.com>
> [...]
> +++ b/drivers/staging/android/alarm-dev.c
> @@ -68,8 +68,8 @@ static struct devalarm alarms[ANDROID_ALARM_TYPE_COUNT];
> */
> static int is_wakeup(enum android_alarm_type type)
> {
> - return (type == ANDROID_ALARM_RTC_WAKEUP ||
> - type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP);
> + return type == ANDROID_ALARM_RTC_WAKEUP ||
> + type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP;
> }
This is the fourth patch that does the exact same, an other similar patch
was already applied, hence this one will not apply. Please base your patches
on -next or the staging.git tree.
--
Regards,
Levente Kurusa
next prev parent reply other threads:[~2014-01-16 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 23:32 [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c Michał Kwiatkowski
2014-01-16 17:51 ` Levente Kurusa [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-01-14 21:28 Michał Kwiatkowski
2014-01-14 21:43 ` Levente Kurusa
2014-01-14 21:58 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D81C09.10901@linux.com \
--to=levex@linux.com \
--cc=cruzjbishop@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michaelflowersky@geekingspree.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).