* [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c
@ 2014-01-15 23:32 Michał Kwiatkowski
2014-01-16 17:51 ` Levente Kurusa
0 siblings, 1 reply; 5+ messages in thread
From: Michał Kwiatkowski @ 2014-01-15 23:32 UTC (permalink / raw)
To: gregkh, john.stultz, dan.carpenter, cruzjbishop
Cc: michaelflowersky, devel, linux-kernel
This is a patch to the alarm-dev.c file that removes parentheses which
should not appear in return statement. This error was found by the
checkpatch.pl tool.
Signed-off-by: Michał Kwiatkowski <michaelflowersky@geekingspree.com>
---
drivers/staging/android/alarm-dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/alarm-dev.c b/drivers/staging/android/alarm-dev.c
index 647694f..96b2f53 100644
--- a/drivers/staging/android/alarm-dev.c
+++ b/drivers/staging/android/alarm-dev.c
@@ -68,8 +68,8 @@ static struct devalarm alarms[ANDROID_ALARM_TYPE_COUNT];
*/
static int is_wakeup(enum android_alarm_type type)
{
- return (type == ANDROID_ALARM_RTC_WAKEUP ||
- type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP);
+ return type == ANDROID_ALARM_RTC_WAKEUP ||
+ type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c
2014-01-15 23:32 [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c Michał Kwiatkowski
@ 2014-01-16 17:51 ` Levente Kurusa
0 siblings, 0 replies; 5+ messages in thread
From: Levente Kurusa @ 2014-01-16 17:51 UTC (permalink / raw)
To: Michał Kwiatkowski, gregkh, john.stultz, dan.carpenter,
cruzjbishop
Cc: devel, linux-kernel
Hello,
On 01/16/2014 12:32 AM, Michał Kwiatkowski wrote:
> This is a patch to the alarm-dev.c file that removes parentheses which
> should not appear in return statement. This error was found by the
> checkpatch.pl tool.
>
> Signed-off-by: Michał Kwiatkowski <michaelflowersky@geekingspree.com>
> [...]
> +++ b/drivers/staging/android/alarm-dev.c
> @@ -68,8 +68,8 @@ static struct devalarm alarms[ANDROID_ALARM_TYPE_COUNT];
> */
> static int is_wakeup(enum android_alarm_type type)
> {
> - return (type == ANDROID_ALARM_RTC_WAKEUP ||
> - type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP);
> + return type == ANDROID_ALARM_RTC_WAKEUP ||
> + type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP;
> }
This is the fourth patch that does the exact same, an other similar patch
was already applied, hence this one will not apply. Please base your patches
on -next or the staging.git tree.
--
Regards,
Levente Kurusa
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c
@ 2014-01-14 21:28 Michał Kwiatkowski
2014-01-14 21:43 ` Levente Kurusa
0 siblings, 1 reply; 5+ messages in thread
From: Michał Kwiatkowski @ 2014-01-14 21:28 UTC (permalink / raw)
To: gregkh, john.stultz, dan.carpenter, cruzjbishop
Cc: michaelflowersky, devel, linux-kernel
From: Michal Kwiatkowski <michaelflowersky@geekingspree.com>
This is a patch to the alarm-dev.c file that removes parentheses which
should not appear in return statement. This error was found by the
checkpatch.pl tool.
Signed-off-by: Michał Kwiatkowski <michaelflowersky@geekingspree.com>
---
drivers/staging/android/alarm-dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/alarm-dev.c b/drivers/staging/android/alarm-dev.c
index 647694f..96b2f53 100644
--- a/drivers/staging/android/alarm-dev.c
+++ b/drivers/staging/android/alarm-dev.c
@@ -68,8 +68,8 @@ static struct devalarm alarms[ANDROID_ALARM_TYPE_COUNT];
*/
static int is_wakeup(enum android_alarm_type type)
{
- return (type == ANDROID_ALARM_RTC_WAKEUP ||
- type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP);
+ return type == ANDROID_ALARM_RTC_WAKEUP ||
+ type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c
2014-01-14 21:28 Michał Kwiatkowski
@ 2014-01-14 21:43 ` Levente Kurusa
2014-01-14 21:58 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Levente Kurusa @ 2014-01-14 21:43 UTC (permalink / raw)
To: Michał Kwiatkowski
Cc: Greg Kroah-Hartman, John Stultz, dan.carpenter, Cruz Bishop,
devel, linux-kernel@vger.kernel.org
Hello,
2014/1/14 Michał Kwiatkowski <michaelflowersky@geekingspree.com>:
> From: Michal Kwiatkowski <michaelflowersky@geekingspree.com>
>
> This is a patch to the alarm-dev.c file that removes parentheses which
> should not appear in return statement. This error was found by the
> checkpatch.pl tool.
>
> Signed-off-by: Michał Kwiatkowski <michaelflowersky@geekingspree.com>
> --
This is like the third patch in this two week period that does the
exact same with more or less success, and I recall one getting applied
(I might be wrong). Anyway, this one finally looks good! :-)
--
Regards,
Levente Kurusa
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c
2014-01-14 21:43 ` Levente Kurusa
@ 2014-01-14 21:58 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2014-01-14 21:58 UTC (permalink / raw)
To: Levente Kurusa
Cc: Michał Kwiatkowski, devel, linux-kernel@vger.kernel.org,
John Stultz, Cruz Bishop, dan.carpenter
On Tue, Jan 14, 2014 at 10:43:04PM +0100, Levente Kurusa wrote:
> Hello,
>
> 2014/1/14 Michał Kwiatkowski <michaelflowersky@geekingspree.com>:
> > From: Michal Kwiatkowski <michaelflowersky@geekingspree.com>
> >
> > This is a patch to the alarm-dev.c file that removes parentheses which
> > should not appear in return statement. This error was found by the
> > checkpatch.pl tool.
> >
> > Signed-off-by: Michał Kwiatkowski <michaelflowersky@geekingspree.com>
> > --
>
> This is like the third patch in this two week period that does the
> exact same with more or less success, and I recall one getting applied
> (I might be wrong). Anyway, this one finally looks good! :-)
You are right, it doesn't apply, Michal should have received my
rejection notice from my patch-bot already saying this.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-01-16 17:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-15 23:32 [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c Michał Kwiatkowski
2014-01-16 17:51 ` Levente Kurusa
-- strict thread matches above, loose matches on Subject: below --
2014-01-14 21:28 Michał Kwiatkowski
2014-01-14 21:43 ` Levente Kurusa
2014-01-14 21:58 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).