From: Florian Meier <florian.meier@koalo.de>
To: Mark Brown <broonie@kernel.org>
Cc: Daniel Matuschek <daniel@matuschek.net>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Dimitris.Papastamos@wolfsonmicro.com,
Liam Girdwood <lgirdwood@gmail.com>,
perex@perex.cz, Takashi Iwai <tiwai@suse.de>,
patches@opensource.wolfsonmicro.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: wm8804: Allow control of master clock divider in PLL generation
Date: Fri, 17 Jan 2014 19:44:02 +0100 [thread overview]
Message-ID: <52D979F2.8070202@koalo.de> (raw)
In-Reply-To: <20140117183332.GC17314@sirena.org.uk>
On 01/17/2014 07:33 PM, Mark Brown wrote:
> On Fri, Jan 17, 2014 at 07:06:24PM +0100, Florian Meier wrote:
>>
> Intentionally off-list?
Oh no - I am sorry!
>> If I remember correctly the error was
>> "codec can not start from non-off bias with idle_bias_off==true"
>
>> I think the solution is just to set idle_bias_off = false and everything
>> seems to be working with that. I just don't know if there might be any
>> side effects.
>
> Setting it to false increases power consumption since the device is
> kept more powered on when idle but reduces startup time from idle. For
> digital only devices like the wm8804 there shouldn't be any reason to
> keep it powered up when not in use, the startup time is generally
> negligable anyway.
>
So a better solution would be to set SND_SOC_BIAS_OFF instead of
SND_SOC_BIAS_STANDBY at the end of probe?
next prev parent reply other threads:[~2014-01-17 18:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 19:34 [PATCH] ASoC: wm8804: Allow control of master clock divider in PLL generation Daniel Matuschek
2014-01-17 0:54 ` Mark Brown
2014-01-17 10:35 ` Dimitris Papastamos
2014-01-22 11:40 ` [alsa-devel] " Ben Dooks
2014-01-17 9:48 ` Charles Keepax
2014-01-17 12:22 ` Mark Brown
2014-01-20 20:03 ` [alsa-devel] " Daniel Matuschek
2014-01-17 16:43 ` Florian Meier
2014-01-17 17:59 ` Mark Brown
2014-01-17 18:26 ` Daniel Matuschek
[not found] ` <52D97120.8030606@koalo.de>
[not found] ` <20140117183332.GC17314@sirena.org.uk>
2014-01-17 18:44 ` Florian Meier [this message]
2014-01-17 18:47 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2014-01-12 21:11 Daniel Matuschek
2014-01-13 9:21 ` Florian Meier
2014-01-13 11:14 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D979F2.8070202@koalo.de \
--to=florian.meier@koalo.de \
--cc=Dimitris.Papastamos@wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel@matuschek.net \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox