From: Souvik Banerjee <souvik1997@gmail.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dell-wmi: Add KEY_SWITCHVIDEOMODE for Dell N4110.
Date: Mon, 20 Jan 2014 10:06:41 -0600 [thread overview]
Message-ID: <52DD4991.4050308@gmail.com> (raw)
In-Reply-To: <52DD492F.1060208@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 989 bytes --]
Forgot to cc the LKML.
-------- Original Message --------
Subject: Re: [PATCH] dell-wmi: Add KEY_SWITCHVIDEOMODE for Dell N4110.
Date: Mon, 20 Jan 2014 10:05:03 -0600
From: Souvik Banerjee <souvik1997@gmail.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
No, I don't think so. My testing shows that it is now just reported by
the keyboard controller. My commit is similar to
'f1566f0dc07ec9b5409b348070f5a700032d7881' in which keys for the Dell
XPS L502X are added to the legacy keymap to reduce the noise. Without
this patch dell-wmi reports an unknown key, but with it those messages
are silenced.
--
Souvik Banerjee
On 01/20/2014 09:31 AM, Matthew Garrett wrote:
> On Mon, Jan 20, 2014 at 09:28:22AM -0600, Souvik Banerjee wrote:
>> This key is reported by the keyboard controller but also generates WMI
>> events. By adding it to the legacy keymap the WMI messages can be
>> silenced.
>
> Wouldn't this result in it being reported twice?
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2014-01-20 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 15:28 [PATCH] dell-wmi: Add KEY_SWITCHVIDEOMODE for Dell N4110 Souvik Banerjee
2014-01-20 15:31 ` Matthew Garrett
[not found] ` <52DD492F.1060208@gmail.com>
2014-01-20 16:06 ` Souvik Banerjee [this message]
[not found] ` <20140120161132.GC3844@srcf.ucam.org>
2014-01-20 16:31 ` Souvik Banerjee
2014-01-20 16:37 ` Matthew Garrett
2014-01-20 16:46 ` Souvik Banerjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DD4991.4050308@gmail.com \
--to=souvik1997@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).