From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Naveen Krishna Ch <naveenkrishna.ch@gmail.com>,
Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: linux-crypto@vger.kernel.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Vladimir Zapolskiy <vzapolskiy@gmail.com>,
herbert@gondor.apana.org.au, cpgs@samsung.com,
tomasz.figa@gmail.com
Subject: Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare
Date: Thu, 23 Jan 2014 11:41:27 +0100 [thread overview]
Message-ID: <52E0F1D7.4030401@samsung.com> (raw)
In-Reply-To: <CAHfPSqCHGbVX3iMC-LNnFYkdutRYFuk07RCeYLU4KAaTpgyQ0w@mail.gmail.com>
Hi,
On 23/01/14 11:18, Naveen Krishna Ch wrote:
> Hello All,
>
> On 15 January 2014 14:47, Naveen Krishna Chatradhi
> <ch.naveen@samsung.com> wrote:
>> This patch set adds use of clk_prepare/clk_unprepare as
>> required by generic clock framework.
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>> ---
>> Changes since v3:
>> None
>>
>> drivers/crypto/s5p-sss.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
>> index f7c66c7..870e794 100644
>> --- a/drivers/crypto/s5p-sss.c
>> +++ b/drivers/crypto/s5p-sss.c
>> @@ -648,7 +648,7 @@ static int s5p_aes_probe(struct platform_device *pdev)
>> return -ENOENT;
>> }
>>
>> - clk_enable(pdata->clk);
>> + clk_prepare_enable(pdata->clk);
How about properly checking the return value ?
--
Thanks,
Sylwester
next prev parent reply other threads:[~2014-01-23 10:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 11:45 [PATCH 8/8 v3] crypto:s5p-sss: Use clk_prepare/clk_unprepare Naveen Krishna Chatradhi
2014-01-10 16:04 ` Tomasz Figa
2014-01-15 9:17 ` [PATCH 8/8 v4] " Naveen Krishna Chatradhi
2014-01-23 10:18 ` Naveen Krishna Ch
2014-01-23 10:41 ` Sylwester Nawrocki [this message]
2014-01-29 7:37 ` Naveen Krishna Ch
2014-01-29 9:26 ` [PATCH 8/9 v5] " Naveen Krishna Chatradhi
2014-02-07 5:26 ` [PATCH 8/9 v6] " Naveen Krishna Chatradhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E0F1D7.4030401@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=ch.naveen@samsung.com \
--cc=cpgs@samsung.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=tomasz.figa@gmail.com \
--cc=vzapolskiy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox