From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>
Subject: Re: AMD microcode loading broken on 32 bit
Date: Thu, 23 Jan 2014 13:08:46 -0500 [thread overview]
Message-ID: <52E15AAE.4090106@oracle.com> (raw)
In-Reply-To: <20140121182554.GE9004@pd.tnic>
On 01/21/2014 01:25 PM, Borislav Petkov wrote:
> On Tue, Jan 21, 2014 at 12:55:53PM -0500, Boris Ostrovsky wrote:
>> cat $(AMD_UCODE_PATH)/* >
>> ucode_initrd/kernel/x86/microcode/AuthenticAMD.bin
>> (cd ucode_initrd;find . | cpio -o -H newc >
>> ../$(DISTDIR)/common/ucode_initrd.cpio)
>> ...
>> cat $(DISTDIR)/common/ucode_initrd.cpio \
>> $(DISTDIR)/common/_initramfs.cpio.gz > \
>> $(DISTDIR)/common/initramfs.cpio.gz
>>
>> and as I just discovered, with a little twist: apparently
>> AMD_UCODE_PATH points to Intel microcode.
> LOL!
>
> @hpa: in case you were wondering whether Intel ucode works on AMD - it
> doesn't! :-)
>
>> So we clearly screwed up on our end but I'd think that we shouldn't
>> crash when this happens.
> Yes, we shouldn't. I'll try to reproduce it here.
So I tried this on a "good" system and I am pretty sure this is broken.
I don't
have any microcode in initrd and I am still dying in load_microcode_amd().
I didn't dig any further but if you can't reproduce this I can look at
what is
a NULL and why. (I suspect it's the 'container' variable).
-boris
next prev parent reply other threads:[~2014-01-23 18:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52DE94A9.9060505@oracle.com>
2014-01-21 16:14 ` AMD microcode loading broken on 32 bit Borislav Petkov
2014-01-21 17:55 ` Boris Ostrovsky
2014-01-21 18:25 ` Borislav Petkov
2014-01-23 18:08 ` Boris Ostrovsky [this message]
2014-01-23 18:54 ` Gene Heskett
2014-01-23 19:09 ` Boris Ostrovsky
2014-01-23 19:36 ` Gene Heskett
2014-01-23 19:29 ` Borislav Petkov
2014-01-23 19:41 ` Boris Ostrovsky
2014-01-28 16:24 ` Borislav Petkov
2014-01-28 20:43 ` Boris Ostrovsky
2014-01-28 20:52 ` Borislav Petkov
2014-01-28 21:05 ` Boris Ostrovsky
2014-01-28 21:30 ` Borislav Petkov
2014-01-28 21:37 ` Boris Ostrovsky
2014-01-28 23:10 ` Boris Ostrovsky
2014-01-28 23:22 ` Borislav Petkov
2014-01-30 15:13 ` Borislav Petkov
2014-01-30 19:41 ` Boris Ostrovsky
2014-01-30 19:54 ` Borislav Petkov
2014-02-03 17:55 ` [PATCH -v2] x86, microcode, AMD: Sanity-check initrd image Borislav Petkov
2014-02-03 19:13 ` Boris Ostrovsky
2014-02-03 19:30 ` Borislav Petkov
2014-02-03 19:37 ` Boris Ostrovsky
2014-02-03 19:52 ` Borislav Petkov
2014-02-03 20:28 ` Boris Ostrovsky
2014-02-03 20:33 ` Borislav Petkov
2014-02-03 20:41 ` [PATCH] x86, microcode, AMD: Unify valid container checks Borislav Petkov
2014-02-06 19:39 ` [tip:x86/urgent] " tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E15AAE.4090106@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox