From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <hpa@zytor.com>,
<x86@kernel.org>, <bp@suse.de>, <linux-kernel@vger.kernel.org>,
<sherry.hurwitz@amd.com>, <hmh@hmh.eng.br>, <Kim.Naru@amd.com>,
<Suravee.Suthikulpanit@amd.com>
Subject: Re: [PATCH] x86, quirks: Add workaround for AMD F16h Erratum792
Date: Thu, 23 Jan 2014 15:55:28 -0600 [thread overview]
Message-ID: <52E18FD0.8030800@amd.com> (raw)
In-Reply-To: <52DECB5A.6030004@amd.com>
On 1/21/2014 1:32 PM, Aravind Gopalakrishnan wrote:
> On 1/20/2014 1:07 AM, Ingo Molnar wrote:
>> * Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> wrote:
>>
>>> +
>>> +#if defined(CONFIG_PCI)
>>> +/*
>>> + * Apply AMD Fam16h Erratum792
>>> + * see Revision Guide for AMD F16h models 00h-0fh,
>>> + * document 51810 rev. 3.04, Nov 2013
>>> + */
>>> +static void quirk_amd_dram_scrub(struct pci_dev *dev)
>> The reference to the erratum is useful for people who want to see more
>> details, but at least a short description of the problem being fixed
>> and systems affected by the quirk is needed. 'DRAM scrub' is not very
>> informative.
>>
>>
> Ok, I'll reword the comment in a V2.
> But there's an internal discussion going on about the erratum, so I'll
> hold off spinning a V2 until that's over..
>
> Thanks,
> -Aravind.
Addressing hpa and Boris' earlier concern
(http://marc.info/?l=linux-kernel&m=138998314409664&w=2)
I can say with better certainty now that there is a coverage hole:
Initial production parts shipped last year, while fix will be in BIOS
only from now onwards; (at least server platforms..)
I have also reworded the comment and function name per Ingo's suggestion..
Sending V2 of patch (rebased off latest tip/master)
Thanks,
-Aravind
prev parent reply other threads:[~2014-01-23 21:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 18:39 [PATCH] x86, quirks: Add workaround for AMD F16h Erratum792 Aravind Gopalakrishnan
2014-01-20 7:07 ` Ingo Molnar
2014-01-21 19:32 ` Aravind Gopalakrishnan
2014-01-23 21:55 ` Aravind Gopalakrishnan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E18FD0.8030800@amd.com \
--to=aravind.gopalakrishnan@amd.com \
--cc=Kim.Naru@amd.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=bp@suse.de \
--cc=hmh@hmh.eng.br \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=sherry.hurwitz@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox