* [PATCH] staging/usbip: Add missing speeds to userspace speed_strings array
@ 2014-01-22 19:53 Shuah Khan
2014-01-24 17:08 ` Thomas Pugliese
0 siblings, 1 reply; 5+ messages in thread
From: Shuah Khan @ 2014-01-22 19:53 UTC (permalink / raw)
To: gregkh, ly80toro, alan
Cc: Shuah Khan, linux-usb, devel, linux-kernel, shuahkhan
Add speed strings for usb wireless and 3.0 to speed_strings array.
Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
---
drivers/staging/usbip/userspace/libsrc/usbip_common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.c b/drivers/staging/usbip/userspace/libsrc/usbip_common.c
index 66f03cc..8cb4fcc 100644
--- a/drivers/staging/usbip/userspace/libsrc/usbip_common.c
+++ b/drivers/staging/usbip/userspace/libsrc/usbip_common.c
@@ -23,6 +23,8 @@ static const struct speed_string speed_strings[] = {
{ USB_SPEED_LOW, "1.5", "Low Speed(1.5Mbps)" },
{ USB_SPEED_FULL, "12", "Full Speed(12Mbps)" },
{ USB_SPEED_HIGH, "480", "High Speed(480Mbps)" },
+ { USB_SPEED_WIRELESS, "2.5", "Wireless"},
+ { USB_SPEED_SUPER, "5000", "Super Speed(5000Mbps)" },
{ 0, NULL, NULL }
};
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging/usbip: Add missing speeds to userspace speed_strings array
2014-01-22 19:53 [PATCH] staging/usbip: Add missing speeds to userspace speed_strings array Shuah Khan
@ 2014-01-24 17:08 ` Thomas Pugliese
2014-01-24 17:12 ` Shuah Khan
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Pugliese @ 2014-01-24 17:08 UTC (permalink / raw)
To: Shuah Khan
Cc: gregkh, ly80toro, alan, linux-usb, devel, linux-kernel, shuahkhan
On Wed, 22 Jan 2014, Shuah Khan wrote:
> Add speed strings for usb wireless and 3.0 to speed_strings array.
>
> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> ---
> drivers/staging/usbip/userspace/libsrc/usbip_common.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.c b/drivers/staging/usbip/userspace/libsrc/usbip_common.c
> index 66f03cc..8cb4fcc 100644
> --- a/drivers/staging/usbip/userspace/libsrc/usbip_common.c
> +++ b/drivers/staging/usbip/userspace/libsrc/usbip_common.c
> @@ -23,6 +23,8 @@ static const struct speed_string speed_strings[] = {
> { USB_SPEED_LOW, "1.5", "Low Speed(1.5Mbps)" },
> { USB_SPEED_FULL, "12", "Full Speed(12Mbps)" },
> { USB_SPEED_HIGH, "480", "High Speed(480Mbps)" },
> + { USB_SPEED_WIRELESS, "2.5", "Wireless"},
> + { USB_SPEED_SUPER, "5000", "Super Speed(5000Mbps)" },
> { 0, NULL, NULL }
> };
>
> --
Wireless USB supports variable speeds from 53.3Mbps to 480Mbps. I'm not
sure how you want to represent that but "2.5" doesn't seem to apply.
Thanks,
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] staging/usbip: Add missing speeds to userspace speed_strings array
2014-01-24 17:08 ` Thomas Pugliese
@ 2014-01-24 17:12 ` Shuah Khan
2014-01-24 17:31 ` Thomas Pugliese
0 siblings, 1 reply; 5+ messages in thread
From: Shuah Khan @ 2014-01-24 17:12 UTC (permalink / raw)
To: Thomas Pugliese
Cc: gregkh, ly80toro, alan, linux-usb, devel, linux-kernel, shuahkhan,
Shuah Khan
On 01/24/2014 10:08 AM, Thomas Pugliese wrote:
>
>
> On Wed, 22 Jan 2014, Shuah Khan wrote:
>
>> Add speed strings for usb wireless and 3.0 to speed_strings array.
>>
>> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
>> ---
>> drivers/staging/usbip/userspace/libsrc/usbip_common.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.c b/drivers/staging/usbip/userspace/libsrc/usbip_common.c
>> index 66f03cc..8cb4fcc 100644
>> --- a/drivers/staging/usbip/userspace/libsrc/usbip_common.c
>> +++ b/drivers/staging/usbip/userspace/libsrc/usbip_common.c
>> @@ -23,6 +23,8 @@ static const struct speed_string speed_strings[] = {
>> { USB_SPEED_LOW, "1.5", "Low Speed(1.5Mbps)" },
>> { USB_SPEED_FULL, "12", "Full Speed(12Mbps)" },
>> { USB_SPEED_HIGH, "480", "High Speed(480Mbps)" },
>> + { USB_SPEED_WIRELESS, "2.5", "Wireless"},
>> + { USB_SPEED_SUPER, "5000", "Super Speed(5000Mbps)" },
>> { 0, NULL, NULL }
>> };
>>
>> --
>
> Wireless USB supports variable speeds from 53.3Mbps to 480Mbps. I'm not
> sure how you want to represent that but "2.5" doesn't seem to apply.
>
Would "variable" be better suited in this case?
-- Shuah
--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] staging/usbip: Add missing speeds to userspace speed_strings array
2014-01-24 17:12 ` Shuah Khan
@ 2014-01-24 17:31 ` Thomas Pugliese
2014-01-24 17:38 ` Shuah Khan
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Pugliese @ 2014-01-24 17:31 UTC (permalink / raw)
To: Shuah Khan
Cc: Thomas Pugliese, gregkh, ly80toro, alan, linux-usb, devel,
linux-kernel, shuahkhan
On Fri, 24 Jan 2014, Shuah Khan wrote:
> On 01/24/2014 10:08 AM, Thomas Pugliese wrote:
> >
> >
> > On Wed, 22 Jan 2014, Shuah Khan wrote:
> >
> > > Add speed strings for usb wireless and 3.0 to speed_strings array.
> > >
> > > Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> > > ---
> > > drivers/staging/usbip/userspace/libsrc/usbip_common.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.c
> > > b/drivers/staging/usbip/userspace/libsrc/usbip_common.c
> > > index 66f03cc..8cb4fcc 100644
> > > --- a/drivers/staging/usbip/userspace/libsrc/usbip_common.c
> > > +++ b/drivers/staging/usbip/userspace/libsrc/usbip_common.c
> > > @@ -23,6 +23,8 @@ static const struct speed_string speed_strings[] = {
> > > { USB_SPEED_LOW, "1.5", "Low Speed(1.5Mbps)" },
> > > { USB_SPEED_FULL, "12", "Full Speed(12Mbps)" },
> > > { USB_SPEED_HIGH, "480", "High Speed(480Mbps)" },
> > > + { USB_SPEED_WIRELESS, "2.5", "Wireless"},
> > > + { USB_SPEED_SUPER, "5000", "Super Speed(5000Mbps)" },
> > > { 0, NULL, NULL }
> > > };
> > >
> > > --
> >
> > Wireless USB supports variable speeds from 53.3Mbps to 480Mbps. I'm not
> > sure how you want to represent that but "2.5" doesn't seem to apply.
> >
>
> Would "variable" be better suited in this case?
>
Sure. You could also use something like "53.3-480" since that would more
closely match the other entires which are numerical values in Mbps units.
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] staging/usbip: Add missing speeds to userspace speed_strings array
2014-01-24 17:31 ` Thomas Pugliese
@ 2014-01-24 17:38 ` Shuah Khan
0 siblings, 0 replies; 5+ messages in thread
From: Shuah Khan @ 2014-01-24 17:38 UTC (permalink / raw)
To: Thomas Pugliese
Cc: gregkh, ly80toro, alan, linux-usb, devel, linux-kernel, shuahkhan,
Shuah Khan
On 01/24/2014 10:31 AM, Thomas Pugliese wrote:
>
>
> On Fri, 24 Jan 2014, Shuah Khan wrote:
>
>> On 01/24/2014 10:08 AM, Thomas Pugliese wrote:
>>>
>>>
>>> On Wed, 22 Jan 2014, Shuah Khan wrote:
>>>
>>>> Add speed strings for usb wireless and 3.0 to speed_strings array.
>>>>
>>>> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
>>>> ---
>>>> drivers/staging/usbip/userspace/libsrc/usbip_common.c | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.c
>>>> b/drivers/staging/usbip/userspace/libsrc/usbip_common.c
>>>> index 66f03cc..8cb4fcc 100644
>>>> --- a/drivers/staging/usbip/userspace/libsrc/usbip_common.c
>>>> +++ b/drivers/staging/usbip/userspace/libsrc/usbip_common.c
>>>> @@ -23,6 +23,8 @@ static const struct speed_string speed_strings[] = {
>>>> { USB_SPEED_LOW, "1.5", "Low Speed(1.5Mbps)" },
>>>> { USB_SPEED_FULL, "12", "Full Speed(12Mbps)" },
>>>> { USB_SPEED_HIGH, "480", "High Speed(480Mbps)" },
>>>> + { USB_SPEED_WIRELESS, "2.5", "Wireless"},
>>>> + { USB_SPEED_SUPER, "5000", "Super Speed(5000Mbps)" },
>>>> { 0, NULL, NULL }
>>>> };
>>>>
>>>> --
>>>
>>> Wireless USB supports variable speeds from 53.3Mbps to 480Mbps. I'm not
>>> sure how you want to represent that but "2.5" doesn't seem to apply.
>>>
>>
>> Would "variable" be better suited in this case?
>>
>
> Sure. You could also use something like "53.3-480" since that would more
> closely match the other entires which are numerical values in Mbps units.
>
> Thomas
>
"53.3-480" sounds good. I will send v2 with that change. Thanks for the
review.
-- Shuah
--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-01-24 17:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-22 19:53 [PATCH] staging/usbip: Add missing speeds to userspace speed_strings array Shuah Khan
2014-01-24 17:08 ` Thomas Pugliese
2014-01-24 17:12 ` Shuah Khan
2014-01-24 17:31 ` Thomas Pugliese
2014-01-24 17:38 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox