[PATCH] x86, hyperv: bypass the timer_irq_works() check

[PATCH] x86, hyperv: bypass the timer_irq_works() check

[Jason Wang]

This patch bypass the timer_irq_works() check for hyperv guest since:

- It was guaranteed to work.
- timer_irq_works() may fail sometime due to the lpj calibration were inaccurate
  in a hyperv guest or a buggy host.

In the future, we should get the tsc frequency from hypervisor and use preset
lpj instead.

Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 arch/x86/kernel/cpu/mshyperv.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
index 9f7ca26..832d05a 100644
--- a/arch/x86/kernel/cpu/mshyperv.c
+++ b/arch/x86/kernel/cpu/mshyperv.c
@@ -26,6 +26,7 @@
 #include <asm/irq_regs.h>
 #include <asm/i8259.h>
 #include <asm/apic.h>
+#include <asm/timer.h>
 
 struct ms_hyperv_info ms_hyperv;
 EXPORT_SYMBOL_GPL(ms_hyperv);
@@ -105,6 +106,11 @@ static void __init ms_hyperv_init_platform(void)
 
 	if (ms_hyperv.features & HV_X64_MSR_TIME_REF_COUNT_AVAILABLE)
 		clocksource_register_hz(&hyperv_cs, NSEC_PER_SEC/100);
+
+#ifdef CONFIG_X86_IO_APIC
+	no_timer_check = 1;
+#endif
+
 }
 
 const __refconst struct hypervisor_x86 x86_hyper_ms_hyperv = {
-- 
1.8.3.2

RE: [PATCH] x86, hyperv: bypass the timer_irq_works() check

[KY Srinivasan]

> -----Original Message-----
> From: Jason Wang [mailto:jasowang@redhat.com]
> Sent: Thursday, January 23, 2014 10:03 PM
> To: KY Srinivasan; Haiyang Zhang; tglx@linutronix.de; mingo@redhat.com;
> hpa@zytor.com; x86@kernel.org; devel@linuxdriverproject.org; linux-
> kernel@vger.kernel.org
> Cc: Jason Wang
> Subject: [PATCH] x86, hyperv: bypass the timer_irq_works() check
> 
> This patch bypass the timer_irq_works() check for hyperv guest since:
> 
> - It was guaranteed to work.
> - timer_irq_works() may fail sometime due to the lpj calibration were inaccurate
>   in a hyperv guest or a buggy host.
> 
> In the future, we should get the tsc frequency from hypervisor and use preset
> lpj instead.
> 
> Cc: K. Y. Srinivasan <kys@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>

Thanks Jason.
Acked-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
>  arch/x86/kernel/cpu/mshyperv.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
> index 9f7ca26..832d05a 100644
> --- a/arch/x86/kernel/cpu/mshyperv.c
> +++ b/arch/x86/kernel/cpu/mshyperv.c
> @@ -26,6 +26,7 @@
>  #include <asm/irq_regs.h>
>  #include <asm/i8259.h>
>  #include <asm/apic.h>
> +#include <asm/timer.h>
> 
>  struct ms_hyperv_info ms_hyperv;
>  EXPORT_SYMBOL_GPL(ms_hyperv);
> @@ -105,6 +106,11 @@ static void __init ms_hyperv_init_platform(void)
> 
>  	if (ms_hyperv.features & HV_X64_MSR_TIME_REF_COUNT_AVAILABLE)
>  		clocksource_register_hz(&hyperv_cs, NSEC_PER_SEC/100);
> +
> +#ifdef CONFIG_X86_IO_APIC
> +	no_timer_check = 1;
> +#endif
> +
>  }
> 
>  const __refconst struct hypervisor_x86 x86_hyper_ms_hyperv = {
> --
> 1.8.3.2

Re: [PATCH] x86, hyperv: bypass the timer_irq_works() check

[H. Peter Anvin]

On 01/23/2014 10:02 PM, Jason Wang wrote:
> This patch bypass the timer_irq_works() check for hyperv guest since:
> 
> - It was guaranteed to work.
> - timer_irq_works() may fail sometime due to the lpj calibration were inaccurate
>   in a hyperv guest or a buggy host.
> 
> In the future, we should get the tsc frequency from hypervisor and use preset
> lpj instead.
> 
> Cc: K. Y. Srinivasan <kys@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>

This should be in -stable, right?

	-hpa

Re: [PATCH] x86, hyperv: bypass the timer_irq_works() check

[Jason Wang]

On 01/25/2014 05:20 AM, H. Peter Anvin wrote:
> On 01/23/2014 10:02 PM, Jason Wang wrote:
>> This patch bypass the timer_irq_works() check for hyperv guest since:
>>
>> - It was guaranteed to work.
>> - timer_irq_works() may fail sometime due to the lpj calibration were inaccurate
>>   in a hyperv guest or a buggy host.
>>
>> In the future, we should get the tsc frequency from hypervisor and use preset
>> lpj instead.
>>
>> Cc: K. Y. Srinivasan <kys@microsoft.com>
>> Cc: Haiyang Zhang <haiyangz@microsoft.com>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
> This should be in -stable, right?
>
> 	-hpa
>
>

Oh, right.

Cc: <stable@vger.kernel.org>

Re: [PATCH] x86, hyperv: bypass the timer_irq_works() check

[Jason Wang]

On 01/26/2014 12:42 PM, Jason Wang wrote:
> On 01/25/2014 05:20 AM, H. Peter Anvin wrote:
>> On 01/23/2014 10:02 PM, Jason Wang wrote:
>>> This patch bypass the timer_irq_works() check for hyperv guest since:
>>>
>>> - It was guaranteed to work.
>>> - timer_irq_works() may fail sometime due to the lpj calibration were inaccurate
>>>   in a hyperv guest or a buggy host.
>>>
>>> In the future, we should get the tsc frequency from hypervisor and use preset
>>> lpj instead.
>>>
>>> Cc: K. Y. Srinivasan <kys@microsoft.com>
>>> Cc: Haiyang Zhang <haiyangz@microsoft.com>
>>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>> This should be in -stable, right?
>>
>> 	-hpa
>>
>>
> Oh, right.
>
> Cc: <stable@vger.kernel.org>

Ping, need I resend the patch or it's ok for you to apply?