From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>,
linux-kernel@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
"David A. Long" <dave.long@linaro.org>,
yrl.pp-manager.tt@hitachi.com, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH -tip 4/8] perf-probe: Use the actual address instead of the symbol name
Date: Sat, 25 Jan 2014 12:04:54 +0900 [thread overview]
Message-ID: <52E329D6.6020700@hitachi.com> (raw)
In-Reply-To: <20140124121340.GA5348@ghostprotocols.net>
(2014/01/24 21:13), Arnaldo Carvalho de Melo wrote:
> Em Fri, Jan 24, 2014 at 10:49:32AM +0900, Masami Hiramatsu escreveu:
>> (2014/01/24 1:12), Steven Rostedt wrote:
>>> On Thu, 23 Jan 2014 11:52:11 -0300
>>> Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:
>>>
>>>> Em Thu, Jan 23, 2014 at 02:29:55AM +0000, Masami Hiramatsu escreveu:
>>>>> Since several local symbols can have same name (e.g. t_show),
>>>>> we need to use the actual address instead of symbol name for
>>>>> those points. Note that this works only with debuginfo.
>>>>>
>>>>> E.g. without this change;
>>>>> ----
>>>>
>>>> Please use spaces after dashed lines, this is even as (or more)
>>>> important as prefixing # lines, as this makes everything after the ---
>>>> line and the patch itself to be ignored.
>>>>
>>
>> Oops, I thought that "----" was safe...
>>
>>> You recommend after? I found adding a single space before the dashes
>>> better, as that way I know I added one and didn't forget to.
>>
>> OK, I'll add at least one space before dashes.
>>
>> BTW, should "#" have two spaces instead of one?
>
> I suggest using two spaces before --- and #, that is what I do and edit
> patches from others when merging, so that would save me some time while
> processing patches.
OK, I'll do it.
I think it also would better change checkpatch.pl to handle it.
Thank you very much! :)
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2014-01-25 3:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 2:29 [PATCH -tip 0/8] perf-probe: Updates for handling local functions correctly Masami Hiramatsu
2014-01-23 2:29 ` [PATCH -tip 1/8] [BUGFIX] perf-probe: Fix to do exit call for symbol maps Masami Hiramatsu
2014-01-23 2:29 ` [PATCH -tip 2/8] [BUGFIX] perf-tools: Load map before using map->map_ip Masami Hiramatsu
2014-01-23 14:43 ` Arnaldo Carvalho de Melo
2014-01-25 14:23 ` [tip:perf/urgent] perf symbols: Load map before using map->map_ip () tip-bot for Masami Hiramatsu
2014-01-23 2:29 ` [PATCH -tip 3/8] perf-probe: Show in what binaries/modules probes are set Masami Hiramatsu
2014-01-23 14:49 ` Arnaldo Carvalho de Melo
2014-01-23 2:29 ` [PATCH -tip 4/8] perf-probe: Use the actual address instead of the symbol name Masami Hiramatsu
2014-01-23 14:52 ` Arnaldo Carvalho de Melo
2014-01-23 16:12 ` Steven Rostedt
2014-01-24 1:49 ` Masami Hiramatsu
2014-01-24 12:13 ` Arnaldo Carvalho de Melo
2014-01-25 3:04 ` Masami Hiramatsu [this message]
2014-01-23 2:29 ` [PATCH -tip 5/8] perf-probe: Show source level information for address only kprobes Masami Hiramatsu
2014-01-23 2:29 ` [PATCH -tip 6/8] perf-probe: Show symbol+offset " Masami Hiramatsu
2014-01-23 2:30 ` [PATCH -tip 7/8] perf-probe: Show source-level or symbol-level info for uprobes Masami Hiramatsu
2014-01-23 2:30 ` [PATCH -tip 8/8] perf-probe: Allow to add events on the local functions Masami Hiramatsu
2014-01-27 10:26 ` [PATCH -tip 0/8] perf-probe: Updates for handling local functions correctly Masami Hiramatsu
2014-01-27 14:46 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E329D6.6020700@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=acme@ghostprotocols.net \
--cc=dave.long@linaro.org \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox