From: Prarit Bhargava <prarit@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@kernel.org>, Yinghai Lu <yinghai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -v2] x86: allocate cpumask during check irq vectors
Date: Sun, 26 Jan 2014 16:46:38 -0500 [thread overview]
Message-ID: <52E5823E.1080906@redhat.com> (raw)
In-Reply-To: <eb93bdba-d16d-4a85-ae40-f265b1db5ed4@email.android.com>
On 01/26/2014 03:29 PM, H. Peter Anvin wrote:
> I strongly disagree with putting variables in file scope when function scope will do, but I do like to see static variables before automatics. Anyway, this is bikeshedding.
>
> Ingo Molnar <mingo@kernel.org> wrote:
>>
>> * H. Peter Anvin <hpa@zytor.com> wrote:
>>
>>> s/global/static/, with a big loud comment why it is okay.
>>
>> It would be a global no matter which form we use, but for
>> maintainability reasons I generally prefer a static put right before
>> the function that uses it:
>>
>> static cpumask_t mask;
>>
>> static func(...)
>> {
>> }
>>
>> That makes it really apparent that it's a global - statics are easily
>> missed when hiding amongst local variables.
Okay, thanks for the input -- I'll put something together and test.
P.
>>
>> Thanks,
>>
>> Ingo
>
next prev parent reply other threads:[~2014-01-26 21:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-25 0:59 [PATCH -v2] x86: allocate cpumask during check irq vectors Yinghai Lu
2014-01-25 8:02 ` Ingo Molnar
2014-01-26 12:22 ` Prarit Bhargava
2014-01-26 13:32 ` Ingo Molnar
2014-01-26 19:19 ` Prarit Bhargava
2014-01-26 20:21 ` Ingo Molnar
2014-01-26 20:23 ` H. Peter Anvin
2014-01-26 20:27 ` Ingo Molnar
2014-01-26 20:29 ` H. Peter Anvin
2014-01-26 21:46 ` Prarit Bhargava [this message]
2014-01-27 7:14 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E5823E.1080906@redhat.com \
--to=prarit@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox