public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: George Cherian <george.cherian@ti.com>, linux-usb@vger.kernel.org
Cc: balbi@ti.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] usb: musb: musb_host: Enable ISOCH IN handling for AM335x host
Date: Mon, 27 Jan 2014 16:44:22 +0400	[thread overview]
Message-ID: <52E654A6.2020601@cogentembedded.com> (raw)
In-Reply-To: <52E62500.7090604@ti.com>

Hello.

On 27-01-2014 13:21, George Cherian wrote:

>>> Enable the isochrounous IN handling for AM335x HOST.
>>> Reprogram CPPI to receive consecutive ISOCH frames in the same URB.

>>    Sigh, I knew CPPI ISO path was broken for years but didn't have time to
>> fix it. :-(

>>> Signed-off-by: George Cherian <george.cherian@ti.com>
>>> --- git rebase
>>>   drivers/usb/musb/musb_host.c | 29 ++++++++++++++++++++++++++---
>>>   1 file changed, 26 insertions(+), 3 deletions(-)

>>> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
>>> index ed45572..5b6482c 100644
>>> --- a/drivers/usb/musb/musb_host.c
>>> +++ b/drivers/usb/musb/musb_host.c
>>> @@ -1689,9 +1689,11 @@ void musb_host_rx(struct musb *musb, u8 epnum)
[...]
>>>           musb_writew(hw_ep->regs, MUSB_RXCSR, val);
>>>
>>> -#if defined(CONFIG_USB_INVENTRA_DMA) || defined(CONFIG_USB_UX500_DMA)
>>> +#if defined(CONFIG_USB_INVENTRA_DMA) || defined(CONFIG_USB_UX500_DMA) || \
>>> +    defined(CONFIG_USB_TI_CPPI41_DMA)

>>    The DaVinci CPPI 3.0 should probably also be included here...

> Should'nt that be a separate patch as this one is specific to AM335X.

    Of course.

WBR, Sergei


  reply	other threads:[~2014-01-27 12:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-24 14:14 [PATCH 0/3] Enable ISOCH IN handling for AM335x George Cherian
2014-01-24 14:14 ` [PATCH 1/3] usb: musb: musb_host: Enable ISOCH IN handling for AM335x host George Cherian
2014-01-24 17:43   ` Sergei Shtylyov
2014-01-27  9:21     ` George Cherian
2014-01-27 12:44       ` Sergei Shtylyov [this message]
2014-01-24 14:14 ` [PATCH 2/3] usb: musb: musb_cppi41: Make CPPI aware of high bandwidth transfers George Cherian
2014-01-24 14:14 ` [PATCH 3/3] usb: musb: musb_cppi41: Handle ISOCH differently and not use the hrtimer George Cherian
2014-01-24 17:46   ` Sergei Shtylyov
2014-01-27  9:24     ` George Cherian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E654A6.2020601@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=balbi@ti.com \
    --cc=george.cherian@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox