From: Jiang Liu <jiang.liu@linux.intel.com>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
David Rientjes <rientjes@google.com>
Cc: Jorg Otte <jrg.otte@gmail.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: reduce log level for message "ACPI: \_PR_.CPU4: failed to get CPU APIC ID"
Date: Tue, 28 Jan 2014 09:20:20 +0800 [thread overview]
Message-ID: <52E705D4.3010806@linux.intel.com> (raw)
In-Reply-To: <52E6F9B9.1070900@intel.com>
On 2014/1/28 8:28, Rafael J. Wysocki wrote:
> On 1/28/2014 1:18 AM, David Rientjes wrote:
>> On Mon, 27 Jan 2014, Jiang Liu wrote:
>>
>>> diff --git a/drivers/acpi/acpi_processor.c
>>> b/drivers/acpi/acpi_processor.c
>>> index c9311be..c29c2c3 100644
>>> --- a/drivers/acpi/acpi_processor.c
>>> +++ b/drivers/acpi/acpi_processor.c
>>> @@ -261,7 +261,7 @@ static int acpi_processor_get_info(struct
>>> acpi_device *device)
>>> apic_id = acpi_get_apicid(pr->handle, device_declaration,
>>> pr->acpi_id);
>>> if (apic_id < 0) {
>>> - acpi_handle_err(pr->handle, "failed to get CPU APIC ID.\n");
>>> + acpi_handle_debug(pr->handle, "failed to get CPU APIC ID.\n");
>>> return -ENODEV;
>>> }
>> Don't we already leave some artifact in the kernel log at boot about apic
>> ids that don't get registered? I'm wondering if we should have this
>> warning at all.
>
> It is useful for knowing that there are potentially broken objects in
> the ACPI tables.
And it's very useful to identify BIOS bug in case of CPU hot-addition.
It caused our test team about 1 week to identify BIOS bug in CPU
hot-addition, so I added this debug message.
Thanks!
Gerry
>
>
prev parent reply other threads:[~2014-01-28 1:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-25 10:03 [kernel 3.13.0-06058-g2d08cd0] Strange ACPI error messages Jörg Otte
2014-01-25 13:53 ` Rafael J. Wysocki
2014-01-25 13:59 ` Rafael J. Wysocki
2014-01-25 16:18 ` Henrique de Moraes Holschuh
2014-01-25 22:31 ` Rafael J. Wysocki
2014-01-26 9:31 ` Jiang Liu
2014-01-25 16:32 ` Jörg Otte
2014-01-25 22:29 ` Rafael J. Wysocki
2014-01-27 6:34 ` [PATCH] ACPI: reduce log level for message "ACPI: \_PR_.CPU4: failed to get CPU APIC ID" Jiang Liu
2014-01-27 9:19 ` Jörg Otte
2014-01-28 0:18 ` David Rientjes
2014-01-28 0:28 ` Rafael J. Wysocki
2014-01-28 1:20 ` Jiang Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E705D4.3010806@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=hmh@hmh.eng.br \
--cc=jrg.otte@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rientjes@google.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox