* [PATCH] ipmi: Add missing rv in ipmi_parisc_probe()
@ 2014-01-28 19:12 Geert Uytterhoeven
2014-01-28 20:21 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2014-01-28 19:12 UTC (permalink / raw)
To: Corey Minyard, Linus Torvalds
Cc: openipmi-developer, linux-parisc, linux-kernel,
Geert Uytterhoeven
drivers/char/ipmi/ipmi_si_intf.c: In function 'ipmi_parisc_probe':
drivers/char/ipmi/ipmi_si_intf.c:2752:2: error: 'rv' undeclared (first use in this function)
drivers/char/ipmi/ipmi_si_intf.c:2752:2: note: each undeclared identifier is reported only once for each function it appears in
Introduced by commit d02b3709ff8efebfca0612d0ac2a6e31a91c13f4 ("ipmi:
Cleanup error return")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
http://kisskb.ellerman.id.au/kisskb/buildresult/10537567/
drivers/char/ipmi/ipmi_si_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 671c3852d359..03f41896d090 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2724,6 +2724,7 @@ static struct platform_driver ipmi_driver = {
static int ipmi_parisc_probe(struct parisc_device *dev)
{
struct smi_info *info;
+ int rv;
info = smi_info_alloc();
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ipmi: Add missing rv in ipmi_parisc_probe()
2014-01-28 19:12 [PATCH] ipmi: Add missing rv in ipmi_parisc_probe() Geert Uytterhoeven
@ 2014-01-28 20:21 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2014-01-28 20:21 UTC (permalink / raw)
To: Geert Uytterhoeven, Linus Torvalds
Cc: openipmi-developer, linux-parisc, linux-kernel
On 01/28/2014 01:12 PM, Geert Uytterhoeven wrote:
> drivers/char/ipmi/ipmi_si_intf.c: In function 'ipmi_parisc_probe':
> drivers/char/ipmi/ipmi_si_intf.c:2752:2: error: 'rv' undeclared (first use in this function)
> drivers/char/ipmi/ipmi_si_intf.c:2752:2: note: each undeclared identifier is reported only once for each function it appears in
>
> Introduced by commit d02b3709ff8efebfca0612d0ac2a6e31a91c13f4 ("ipmi:
> Cleanup error return")
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Dang it. Yes, you are right, of course.
Acked-by: Corey Minyard <cminyard@mvista.com>
> ---
> http://kisskb.ellerman.id.au/kisskb/buildresult/10537567/
>
> drivers/char/ipmi/ipmi_si_intf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 671c3852d359..03f41896d090 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -2724,6 +2724,7 @@ static struct platform_driver ipmi_driver = {
> static int ipmi_parisc_probe(struct parisc_device *dev)
> {
> struct smi_info *info;
> + int rv;
>
> info = smi_info_alloc();
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-28 20:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-28 19:12 [PATCH] ipmi: Add missing rv in ipmi_parisc_probe() Geert Uytterhoeven
2014-01-28 20:21 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox