From: Chris Metcalf <cmetcalf@tilera.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tile: remove compat_sys_lookup_dcookie declaration to fix compile error
Date: Fri, 31 Jan 2014 10:55:57 -0500 [thread overview]
Message-ID: <52EBC78D.9060805@tilera.com> (raw)
In-Reply-To: <20140131065036.GB4114@osiris>
On 1/31/2014 1:50 AM, Heiko Carstens wrote:
> With d8d14bd09cdd "fs/compat: fix lookup_dcookie() parameter handling" I
> changed the type of the len parameter of the lookup_dcookie() syscall.
>
> However I missed that there was still a stale declaration in arch/tile/..
> which now causes a compile error on tile:
>
> In file included from fs/dcookies.c:28:0:
> include/linux/compat.h:425:17: error: conflicting types for 'compat_sys_lookup_dcookie'
> fs/dcookies.c:207:1: error: conflicting types for 'compat_sys_lookup_dcookie'
>
> Simply remove the declaration in the tile architecture, which is only a
> leftover from before the different compat lookup_dcookie() versions have
> been merged.
> The declaration is now in include/linux/compat.h
>
> The build error was reported by Fenguang's build bot.
>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Acked-by: Chris Metcalf <cmetcalf@tilera.com>
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
prev parent reply other threads:[~2014-01-31 16:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 6:50 [PATCH] tile: remove compat_sys_lookup_dcookie declaration to fix compile error Heiko Carstens
2014-01-31 15:55 ` Chris Metcalf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EBC78D.9060805@tilera.com \
--to=cmetcalf@tilera.com \
--cc=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).