Re: Would devm_regulator_enable be useful ?

Mark Brown
2014-02-03T18:22:00Z

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

On Sat, Feb 01, 2014 at 04:23:59PM -0800, Guenter Roeck wrote:

As previously mentioned please fix your mailer to word wrap at a
sensible limit.

> Seems to me it would be useful to have it, but then devm_clk_enable()
> doesn't exist either, so I wonder if there is a reason for not having
> it.

In both cases enabling and then leaving the resource enabled throughout
the runtime of the device isn't normally the best practice for using
them. You usually want to enable and disable at runtime with mechanisms
like runtime PM when the device is idle rather than burning power all
the time and once you start doing that managed resources don't fit so
well.