public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: stefani@seibold.net, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
	mingo@redhat.com, ak@linux.intel.com, aarcange@redhat.com,
	john.stultz@linaro.org, luto@amacapital.net, xemul@parallels.com,
	gorcunov@openvz.org, andriy.shevchenko@linux.intel.com
Cc: Martin.Runge@rohde-schwarz.com, Andreas.Brief@rohde-schwarz.com
Subject: Re: [PATCH v9 7/8] Add 32 bit VDSO time support for 32 bit kernel
Date: Sun, 02 Feb 2014 13:45:59 -0800	[thread overview]
Message-ID: <52EEBC97.50509@zytor.com> (raw)
In-Reply-To: <1391377293-9458-8-git-send-email-stefani@seibold.net>

On 02/02/2014 01:41 PM, stefani@seibold.net wrote:
> @@ -19,11 +22,14 @@ ENTRY(__kernel_vsyscall);
>   */
>  VERSION
>  {
> -	LINUX_2.5 {
> +	LINUX_2.6 {
>  	global:

Why are you changing the version number?  This will, at least in theory,
break libcs from a certain time period.  The version number should only
be changed when there is an ABI-level incompatible change.

	-hpa



  reply	other threads:[~2014-02-02 21:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-02 21:41 [PATCH v9 0/8] Add 32 bit VDSO time function support stefani
2014-02-02 21:41 ` [PATCH v9 1/8] Make vsyscall_gtod_data handling x86 generic stefani
2014-02-02 21:41 ` [PATCH v9 2/8] Add new func _install_special_mapping() to mmap.c stefani
2014-02-02 21:41 ` [PATCH v9 3/8] revamp vclock_gettime.c stefani
2014-02-02 21:41 ` [PATCH v9 4/8] vclock_gettime.c __vdso_clock_gettime cleanup stefani
2014-02-02 21:41 ` [PATCH v9 5/8] replace VVAR(vsyscall_gtod_data) by gtod macro stefani
2014-02-02 21:41 ` [PATCH v9 6/8] cleanup __vdso_gettimeofday stefani
2014-02-02 21:41 ` [PATCH v9 7/8] Add 32 bit VDSO time support for 32 bit kernel stefani
2014-02-02 21:45   ` H. Peter Anvin [this message]
2014-02-02 21:41 ` [PATCH v9 8/8] Add 32 bit VDSO time support for 64 " stefani
2014-02-02 22:26   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52EEBC97.50509@zytor.com \
    --to=hpa@zytor.com \
    --cc=Andreas.Brief@rohde-schwarz.com \
    --cc=Martin.Runge@rohde-schwarz.com \
    --cc=aarcange@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gorcunov@openvz.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@redhat.com \
    --cc=stefani@seibold.net \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox