* [PATCH] watchdog,dw: Add dependency on HAS_IOMEM
@ 2014-01-31 12:47 Richard Weinberger
2014-02-03 8:58 ` Wim Van Sebroeck
0 siblings, 1 reply; 4+ messages in thread
From: Richard Weinberger @ 2014-01-31 12:47 UTC (permalink / raw)
To: wim; +Cc: linux-watchdog, linux-kernel, Richard Weinberger
On archs like S390 or um this driver cannot build nor work.
Make it depend on HAS_IOMEM to bypass build failures.
drivers/built-in.o: In function `dw_wdt_drv_probe':
drivers/watchdog/dw_wdt.c:302: undefined reference to `devm_ioremap_resource'
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/watchdog/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 4c4c566..79d2589 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -223,6 +223,7 @@ config SA1100_WATCHDOG
config DW_WATCHDOG
tristate "Synopsys DesignWare watchdog"
+ depends on HAS_IOMEM
help
Say Y here if to include support for the Synopsys DesignWare
watchdog timer found in many chips.
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog,dw: Add dependency on HAS_IOMEM
2014-01-31 12:47 [PATCH] watchdog,dw: Add dependency on HAS_IOMEM Richard Weinberger
@ 2014-02-03 8:58 ` Wim Van Sebroeck
2014-02-03 9:13 ` Richard Weinberger
0 siblings, 1 reply; 4+ messages in thread
From: Wim Van Sebroeck @ 2014-02-03 8:58 UTC (permalink / raw)
To: Richard Weinberger; +Cc: linux-watchdog, linux-kernel
Hi Richard,
> On archs like S390 or um this driver cannot build nor work.
> Make it depend on HAS_IOMEM to bypass build failures.
>
> drivers/built-in.o: In function `dw_wdt_drv_probe':
> drivers/watchdog/dw_wdt.c:302: undefined reference to `devm_ioremap_resource'
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
Patch added to linux-watchdog-next.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog,dw: Add dependency on HAS_IOMEM
2014-02-03 8:58 ` Wim Van Sebroeck
@ 2014-02-03 9:13 ` Richard Weinberger
2014-02-03 10:39 ` Wim Van Sebroeck
0 siblings, 1 reply; 4+ messages in thread
From: Richard Weinberger @ 2014-02-03 9:13 UTC (permalink / raw)
To: Wim Van Sebroeck; +Cc: linux-watchdog, linux-kernel
Am 03.02.2014 09:58, schrieb Wim Van Sebroeck:
> Hi Richard,
>
>> On archs like S390 or um this driver cannot build nor work.
>> Make it depend on HAS_IOMEM to bypass build failures.
>>
>> drivers/built-in.o: In function `dw_wdt_drv_probe':
>> drivers/watchdog/dw_wdt.c:302: undefined reference to `devm_ioremap_resource'
>>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>
> Patch added to linux-watchdog-next.
-next in terms of 3.15 material?
Please push this as soon as possible to Linus such that the build works on said archs.
Thanks,
//richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog,dw: Add dependency on HAS_IOMEM
2014-02-03 9:13 ` Richard Weinberger
@ 2014-02-03 10:39 ` Wim Van Sebroeck
0 siblings, 0 replies; 4+ messages in thread
From: Wim Van Sebroeck @ 2014-02-03 10:39 UTC (permalink / raw)
To: Richard Weinberger; +Cc: linux-watchdog, linux-kernel
Hi Richard,
> >> On archs like S390 or um this driver cannot build nor work.
> >> Make it depend on HAS_IOMEM to bypass build failures.
> >>
> >> drivers/built-in.o: In function `dw_wdt_drv_probe':
> >> drivers/watchdog/dw_wdt.c:302: undefined reference to `devm_ioremap_resource'
> >>
> >> Signed-off-by: Richard Weinberger <richard@nod.at>
> >
> > Patch added to linux-watchdog-next.
>
> -next in terms of 3.15 material?
> Please push this as soon as possible to Linus such that the build works on said archs.
No, next in terms of a couple of days testing also.
This will go out before 3.14-rc2 is there.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-03 10:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-31 12:47 [PATCH] watchdog,dw: Add dependency on HAS_IOMEM Richard Weinberger
2014-02-03 8:58 ` Wim Van Sebroeck
2014-02-03 9:13 ` Richard Weinberger
2014-02-03 10:39 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox