public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Andrew Chew <achew@nvidia.com>,
	tglx@linutronix.de, swarren@wwwdotorg.org,
	thierry.reding@gmail.com, abrestic@chromium.org,
	dgreid@chromium.org, katierh@chromium.org
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1] clocksource: tegra: Add nvidia,tegra30-timer compat
Date: Mon, 03 Feb 2014 17:39:46 +0100	[thread overview]
Message-ID: <52EFC652.9000209@linaro.org> (raw)
In-Reply-To: <1391203779-5676-1-git-send-email-achew@nvidia.com>

On 01/31/2014 10:29 PM, Andrew Chew wrote:
> There are some differences between tegra20's timer registers and tegra30's
> (and later).  For one thing, the watchdogs don't seem to be present in
> tegra20.

"don't seem", so it is an assumption ?

> Add this compatibility string in order to be able to distinguish
> whether the watchdogs are there or not.

Sorry but I don't get the connection between declaring the tegra30_timer 
and the log. Can you elaborate please ?

> Signed-off-by: Andrew Chew <achew@nvidia.com>
> ---
>   drivers/clocksource/tegra20_timer.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/tegra20_timer.c b/drivers/clocksource/tegra20_timer.c
> index d1869f0..73cfa56 100644
> --- a/drivers/clocksource/tegra20_timer.c
> +++ b/drivers/clocksource/tegra20_timer.c
> @@ -218,6 +218,7 @@ static void __init tegra20_init_timer(struct device_node *np)
>   					0x1, 0x1fffffff);
>   }
>   CLOCKSOURCE_OF_DECLARE(tegra20_timer, "nvidia,tegra20-timer", tegra20_init_timer);
> +CLOCKSOURCE_OF_DECLARE(tegra30_timer, "nvidia,tegra30-timer", tegra20_init_timer);
>
>   static void __init tegra20_init_rtc(struct device_node *np)
>   {
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


  reply	other threads:[~2014-02-03 16:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-31 21:29 [PATCH v1] clocksource: tegra: Add nvidia,tegra30-timer compat Andrew Chew
2014-02-03 16:39 ` Daniel Lezcano [this message]
2014-02-03 18:54   ` Andrew Chew
2014-02-04 19:10     ` Thomas Gleixner
2014-02-04 19:14       ` Andrew Chew
2014-02-04 20:22         ` Thomas Gleixner
2014-02-03 21:07 ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52EFC652.9000209@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=abrestic@chromium.org \
    --cc=achew@nvidia.com \
    --cc=dgreid@chromium.org \
    --cc=katierh@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=tglx@linutronix.de \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox