From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753832AbaBCTK5 (ORCPT ); Mon, 3 Feb 2014 14:10:57 -0500 Received: from co9ehsobe001.messaging.microsoft.com ([207.46.163.24]:16059 "EHLO co9outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753790AbaBCTKy (ORCPT ); Mon, 3 Feb 2014 14:10:54 -0500 X-Forefront-Antispam-Report: CIP:165.204.84.221;KIP:(null);UIP:(null);IPV:NLI;H:atltwp01.amd.com;RD:none;EFVD:NLI X-SpamScore: -4 X-BigFish: VPS-4(z579ehzbb2dI98dI9371I1432Izz1f42h2148h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h2189h1d1ah1d2ah21bch1fc6hzdchz1de098h17326ah8275bh1de097h186068hz2dh839h947hd25he5bhf0ah1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h1765h18e1h190ch1946h19b4h19c3h1ad9h1b0ah2222h224fh1d0ch1d2eh1d3fh1dfeh1dffh1f5fh1fe8h1ff5h209eh22d0h2336h2438h2461h2487h24d7h2516h1155h) X-WSS-ID: 0N0FP9Z-07-577-02 X-M-MSG: Message-ID: <52EFE9B2.9020104@amd.com> Date: Mon, 3 Feb 2014 13:10:42 -0600 From: Aravind Gopalakrishnan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: , , , Subject: Re: [PATCH] AMD64_EDAC: Fix logic to determine channel for F15 M30h processors References: <1390338216-3873-1-git-send-email-Aravind.Gopalakrishnan@amd.com> In-Reply-To: <1390338216-3873-1-git-send-email-Aravind.Gopalakrishnan@amd.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-OriginatorOrg: amd.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/21/2014 3:03 PM, Aravind Gopalakrishnan wrote: > The current logic that returns (sys_addr >> 8) & 0x7 when > num_dcts_intlv = 4 is incorrect. We should really be doing- > If intlv_addr = 0x4, then interleave on bits [9:8] and if > intlv_addr = 0x5, interleave on bits [10:9]. > > Refer F15 M30h BKDG D18F2x110[7:6] (DRAM Controller Select Low) > (Link:http://support.amd.com/TechDocs/49125_15h_Models_30h-3Fh_BKDG.pdf) > > Tested on F15 M30h with mce_inj module and patch did not cause > any regressions. > > Signed-off-by: Aravind Gopalakrishnan > --- > Ping.. -Aravind.