From: Stephen Warren <swarren@wwwdotorg.org>
To: Andrew Chew <achew@nvidia.com>,
daniel.lezcano@linaro.org, tglx@linutronix.de,
thierry.reding@gmail.com, rob@landley.net,
grant.likely@linaro.org, robh+dt@kernel.org,
abrestic@chromium.org, dgreid@chromium.org, katierh@chromium.org
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 1/3] clocksource: tegra: Add nvidia,tegra30-timer compat
Date: Wed, 05 Feb 2014 13:04:59 -0700 [thread overview]
Message-ID: <52F2996B.4080005@wwwdotorg.org> (raw)
In-Reply-To: <1391473055-3158-2-git-send-email-achew@nvidia.com>
On 02/03/2014 05:17 PM, Andrew Chew wrote:
> There are some differences between tegra20's timer registers and tegra30's
> (and later). For example, tegra30 has more timers. In addition, watchdogs
> are not present in tegra20.
>
> Add this compatibility string in order to be able to distinguish
> whether the additional timers and watchdogs are there or not.
> diff --git a/drivers/clocksource/tegra20_timer.c b/drivers/clocksource/tegra20_timer.c
> CLOCKSOURCE_OF_DECLARE(tegra20_timer, "nvidia,tegra20-timer", tegra20_init_timer);
> +CLOCKSOURCE_OF_DECLARE(tegra30_timer, "nvidia,tegra30-timer", tegra20_init_timer);
Thinking about this more, nothing in this driver actually cares about
Tegra20 vs. Tegra30+, since the timer that's used is present in all
chips. Hence, this patch isn't needed.
next prev parent reply other threads:[~2014-02-05 20:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 0:17 [PATCH v2 0/3] tegra30 watchdog support Andrew Chew
2014-02-04 0:17 ` [PATCH v2 1/3] clocksource: tegra: Add nvidia,tegra30-timer compat Andrew Chew
2014-02-05 20:04 ` Stephen Warren [this message]
2014-02-05 20:06 ` Andrew Chew
2014-02-05 20:17 ` Stephen Warren
2014-02-05 21:39 ` Andrew Chew
2014-02-04 0:17 ` [PATCH v2 2/3] clocksource: tegra: Define timer bases in header file Andrew Chew
2014-02-04 7:54 ` Daniel Lezcano
2014-02-04 18:55 ` Andrew Chew
2014-02-05 20:03 ` Stephen Warren
2014-02-05 21:41 ` Andrew Chew
2014-02-04 0:17 ` [PATCH v2 3/3] watchdog: Add tegra watchdog Andrew Chew
2014-02-05 20:14 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F2996B.4080005@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=abrestic@chromium.org \
--cc=achew@nvidia.com \
--cc=daniel.lezcano@linaro.org \
--cc=dgreid@chromium.org \
--cc=grant.likely@linaro.org \
--cc=katierh@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).