linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Hennerich <michael.hennerich@analog.com>
To: Jingoo Han <jg1.han@samsung.com>,
	"'Andrew Morton'" <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>, "'Mike Frysinger'" <vapier@gentoo.org>
Subject: Re: [PATCH 03/12] backlight: adp8870: Remove unnecessary OOM messages
Date: Thu, 6 Feb 2014 11:42:27 +0100	[thread overview]
Message-ID: <52F36713.1070107@analog.com> (raw)
In-Reply-To: <000401cf2313$f2297df0$d67c79d0$%han@samsung.com>

On 02/06/2014 09:17 AM, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
>   drivers/video/backlight/adp8870_bl.c |    4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c
> index 6370720..251af4d 100644
> --- a/drivers/video/backlight/adp8870_bl.c
> +++ b/drivers/video/backlight/adp8870_bl.c
> @@ -246,10 +246,8 @@ static int adp8870_led_probe(struct i2c_client *client)
>   
>   	led = devm_kzalloc(&client->dev, pdata->num_leds * sizeof(*led),
>   				GFP_KERNEL);
> -	if (led == NULL) {
> -		dev_err(&client->dev, "failed to alloc memory\n");
> +	if (led == NULL)
>   		return -ENOMEM;
> -	}
>   
>   	ret = adp8870_write(client, ADP8870_ISCLAW, pdata->led_fade_law);
>   	if (ret)


-- 
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif



  reply	other threads:[~2014-02-06 10:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-06  8:14 [PATCH 00/12] backlight: Remove unnecessary OOM messages Jingoo Han
2014-02-06  8:16 ` [PATCH 01/12] backlight: aat2870: " Jingoo Han
2014-02-07  6:18   ` jinyoungp
2014-02-06  8:16 ` [PATCH 02/12] backlight: adp8860: " Jingoo Han
2014-02-06  8:17 ` [PATCH 03/12] backlight: adp8870: " Jingoo Han
2014-02-06 10:42   ` Michael Hennerich [this message]
2014-02-06  8:19 ` [PATCH 04/12] backlight: corgi_lcd: " Jingoo Han
2014-02-06  8:20 ` [PATCH 05/12] backlight: hx8357: " Jingoo Han
2014-02-06  8:31   ` 'Maxime Ripard'
2014-02-06  8:21 ` [PATCH 06/12] backlight: ili922x: " Jingoo Han
2014-02-06  9:15   ` Stefano Babic
2014-02-06  8:22 ` [PATCH 07/12] backlight: ili9320: " Jingoo Han
2014-02-06  8:24 ` [PATCH 08/12] backlight: l4f00242t03: " Jingoo Han
2014-02-06  8:25 ` [PATCH 09/12] backlight: lm3533_bl: " Jingoo Han
2014-02-06 16:06   ` 'Johan Hovold'
2014-02-06  8:26 ` [PATCH 10/12] backlight: lms283gf05: " Jingoo Han
2014-02-06 13:34   ` Marek Vasut
2014-02-06  8:31 ` [PATCH 11/12] backlight: platform_lcd: " Jingoo Han
2014-02-06  8:32 ` [PATCH 12/12] backlight: tps65217_bl: " Jingoo Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F36713.1070107@analog.com \
    --to=michael.hennerich@analog.com \
    --cc=akpm@linux-foundation.org \
    --cc=jg1.han@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).