public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Use realpath for srctree and objtree
@ 2014-01-26 10:06 Wang Nan
  2014-01-26 16:30 ` Jiri Olsa
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Wang Nan @ 2014-01-26 10:06 UTC (permalink / raw)
  To: linux-kernel
  Cc: Wang Nan, Sasha Levin, Arnaldo Carvalho de Melo, Jiri Olsa,
	Steven Rostedt, Namhyung Kim, Geng Hui

When BUILD_SRC contains a tailing '/', the file name used in compiling command
will contain '//', and it then goes to .o's debuginfo, confuses debugedit:

https://bugzilla.redhat.com/show_bug.cgi?id=304121

This patch uses realpath to makesure srctree and objtree don't have tailing '/'.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: Sasha Levin <sasha.levin@oracle.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Geng Hui <hui.geng@huawei.com>

---
 tools/lib/lockdep/Makefile    | 4 ++--
 tools/lib/traceevent/Makefile | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/lib/lockdep/Makefile b/tools/lib/lockdep/Makefile
index da8b7aa..e638dd5 100644
--- a/tools/lib/lockdep/Makefile
+++ b/tools/lib/lockdep/Makefile
@@ -87,8 +87,8 @@ endif # BUILD_SRC
 # We process the rest of the Makefile if this is the final invocation of make
 ifeq ($(skip-makefile),)
 
-srctree		:= $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR))
-objtree		:= $(CURDIR)
+srctree		:= $(realpath $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR)))
+objtree		:= $(realpath $(CURDIR))
 src		:= $(srctree)
 obj		:= $(objtree)
 
diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
index 56d52a3..dd23171 100644
--- a/tools/lib/traceevent/Makefile
+++ b/tools/lib/traceevent/Makefile
@@ -107,8 +107,8 @@ endif # BUILD_SRC
 # We process the rest of the Makefile if this is the final invocation of make
 ifeq ($(skip-makefile),)
 
-srctree		:= $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR))
-objtree		:= $(CURDIR)
+srctree		:= $(realpath $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR)))
+objtree		:= $(realpath $(CURDIR))
 src		:= $(srctree)
 obj		:= $(objtree)
 
-- 
1.8.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] Use realpath for srctree and objtree
  2014-01-26 10:06 [PATCH] Use realpath for srctree and objtree Wang Nan
@ 2014-01-26 16:30 ` Jiri Olsa
  2014-01-28 17:14 ` Sasha Levin
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Jiri Olsa @ 2014-01-26 16:30 UTC (permalink / raw)
  To: Wang Nan
  Cc: linux-kernel, Sasha Levin, Arnaldo Carvalho de Melo,
	Steven Rostedt, Namhyung Kim, Geng Hui

On Sun, Jan 26, 2014 at 06:06:18PM +0800, Wang Nan wrote:
> When BUILD_SRC contains a tailing '/', the file name used in compiling command
> will contain '//', and it then goes to .o's debuginfo, confuses debugedit:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=304121
> 
> This patch uses realpath to makesure srctree and objtree don't have tailing '/'.
> 
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> Cc: Sasha Levin <sasha.levin@oracle.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Geng Hui <hui.geng@huawei.com>
> 
> ---
>  tools/lib/lockdep/Makefile    | 4 ++--
>  tools/lib/traceevent/Makefile | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/lib/lockdep/Makefile b/tools/lib/lockdep/Makefile
> index da8b7aa..e638dd5 100644
> --- a/tools/lib/lockdep/Makefile
> +++ b/tools/lib/lockdep/Makefile
> @@ -87,8 +87,8 @@ endif # BUILD_SRC
>  # We process the rest of the Makefile if this is the final invocation of make
>  ifeq ($(skip-makefile),)
>  
> -srctree		:= $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR))
> -objtree		:= $(CURDIR)
> +srctree		:= $(realpath $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR)))
> +objtree		:= $(realpath $(CURDIR))
>  src		:= $(srctree)
>  obj		:= $(objtree)
>  
> diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
> index 56d52a3..dd23171 100644
> --- a/tools/lib/traceevent/Makefile
> +++ b/tools/lib/traceevent/Makefile
> @@ -107,8 +107,8 @@ endif # BUILD_SRC
>  # We process the rest of the Makefile if this is the final invocation of make
>  ifeq ($(skip-makefile),)
>  
> -srctree		:= $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR))
> -objtree		:= $(CURDIR)
> +srctree		:= $(realpath $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR)))
> +objtree		:= $(realpath $(CURDIR))
>  src		:= $(srctree)
>  obj		:= $(objtree)

ack for the traceevent change

thanks,
jirka

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Use realpath for srctree and objtree
  2014-01-26 10:06 [PATCH] Use realpath for srctree and objtree Wang Nan
  2014-01-26 16:30 ` Jiri Olsa
@ 2014-01-28 17:14 ` Sasha Levin
  2014-02-08  1:43 ` [PATCH resend 1/2] liblockdep: " Wang Nan
  2014-02-08  1:44 ` [PATCH resend 2/2] tools lib traceevent: " Wang Nan
  3 siblings, 0 replies; 6+ messages in thread
From: Sasha Levin @ 2014-01-28 17:14 UTC (permalink / raw)
  To: Wang Nan, linux-kernel
  Cc: Arnaldo Carvalho de Melo, Jiri Olsa, Steven Rostedt, Namhyung Kim,
	Geng Hui

On 01/26/2014 05:06 AM, Wang Nan wrote:
> When BUILD_SRC contains a tailing '/', the file name used in compiling command
> will contain '//', and it then goes to .o's debuginfo, confuses debugedit:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=304121
>
> This patch uses realpath to makesure srctree and objtree don't have tailing '/'.
>
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> Cc: Sasha Levin <sasha.levin@oracle.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Geng Hui <hui.geng@huawei.com>
>
> ---

For the liblockdep changes:

	Acked-by: Sasha Levin <sasha.levin@oracle.com>
	

Thanks,
Sasha

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH resend 1/2] liblockdep: Use realpath for srctree and objtree
  2014-01-26 10:06 [PATCH] Use realpath for srctree and objtree Wang Nan
  2014-01-26 16:30 ` Jiri Olsa
  2014-01-28 17:14 ` Sasha Levin
@ 2014-02-08  1:43 ` Wang Nan
  2014-02-08 23:14   ` Sasha Levin
  2014-02-08  1:44 ` [PATCH resend 2/2] tools lib traceevent: " Wang Nan
  3 siblings, 1 reply; 6+ messages in thread
From: Wang Nan @ 2014-02-08  1:43 UTC (permalink / raw)
  To: linux-kernel; +Cc: Sasha Levin, Wang Nan, Ingo Molnar, Andrew Morton, Geng Hui

If BUILD_SRC or CURDIR contains tailing '/', the file names passed to gcc will
contain '//'. It will be contained .o's in debuginfo, then confuse debugedit:

https://bugzilla.redhat.com/show_bug.cgi?id=304121

This patch uses realpath command to makesure potential tailing '/'s are removed.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Sasha Levin <sasha.levin@oracle.com> 
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Geng Hui <hui.geng@huawei.com>

---
 tools/lib/lockdep/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/lib/lockdep/Makefile b/tools/lib/lockdep/Makefile
index da8b7aa..e638dd5 100644
--- a/tools/lib/lockdep/Makefile
+++ b/tools/lib/lockdep/Makefile
@@ -87,8 +87,8 @@ endif # BUILD_SRC
 # We process the rest of the Makefile if this is the final invocation of make
 ifeq ($(skip-makefile),)
 
-srctree		:= $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR))
-objtree		:= $(CURDIR)
+srctree		:= $(realpath $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR)))
+objtree		:= $(realpath $(CURDIR))
 src		:= $(srctree)
 obj		:= $(objtree)
 
-- 
1.8.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH resend 2/2] tools lib traceevent: Use realpath for srctree and objtree
  2014-01-26 10:06 [PATCH] Use realpath for srctree and objtree Wang Nan
                   ` (2 preceding siblings ...)
  2014-02-08  1:43 ` [PATCH resend 1/2] liblockdep: " Wang Nan
@ 2014-02-08  1:44 ` Wang Nan
  3 siblings, 0 replies; 6+ messages in thread
From: Wang Nan @ 2014-02-08  1:44 UTC (permalink / raw)
  To: linux-kernel
  Cc: Jiri Olsa, Wang Nan, Arnaldo Carvalho de Melo, Steven Rostedt,
	Namhyung Kim, Ingo Molnar, Andrew Morton, Geng Hui

If BUILD_SRC or CURDIR contains tailing '/', the file names passed to gcc will
contain '//'. It will be contained .o's in debuginfo, then confuse debugedit:

https://bugzilla.redhat.com/show_bug.cgi?id=304121

This patch uses realpath command to makesure potential tailing '/'s are removed.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Geng Hui <hui.geng@huawei.com>

---
 tools/lib/traceevent/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
index 005c9cc..5bb281c 100644
--- a/tools/lib/traceevent/Makefile
+++ b/tools/lib/traceevent/Makefile
@@ -107,8 +107,8 @@ endif # BUILD_SRC
 # We process the rest of the Makefile if this is the final invocation of make
 ifeq ($(skip-makefile),)
 
-srctree		:= $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR))
-objtree		:= $(CURDIR)
+srctree		:= $(realpath $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR)))
+objtree		:= $(realpath $(CURDIR))
 src		:= $(srctree)
 obj		:= $(objtree)
 
-- 
1.8.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH resend 1/2] liblockdep: Use realpath for srctree and objtree
  2014-02-08  1:43 ` [PATCH resend 1/2] liblockdep: " Wang Nan
@ 2014-02-08 23:14   ` Sasha Levin
  0 siblings, 0 replies; 6+ messages in thread
From: Sasha Levin @ 2014-02-08 23:14 UTC (permalink / raw)
  To: Wang Nan, linux-kernel; +Cc: Ingo Molnar, Andrew Morton, Geng Hui

Hi Wang,

Thanks! I've picked it up and will send it in the next pull request.


Thanks,
Sasha

On 02/07/2014 08:43 PM, Wang Nan wrote:
> If BUILD_SRC or CURDIR contains tailing '/', the file names passed to gcc will
> contain '//'. It will be contained .o's in debuginfo, then confuse debugedit:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=304121
>
> This patch uses realpath command to makesure potential tailing '/'s are removed.
>
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> Acked-by: Sasha Levin <sasha.levin@oracle.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Geng Hui <hui.geng@huawei.com>
>
> ---
>   tools/lib/lockdep/Makefile | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/lib/lockdep/Makefile b/tools/lib/lockdep/Makefile
> index da8b7aa..e638dd5 100644
> --- a/tools/lib/lockdep/Makefile
> +++ b/tools/lib/lockdep/Makefile
> @@ -87,8 +87,8 @@ endif # BUILD_SRC
>   # We process the rest of the Makefile if this is the final invocation of make
>   ifeq ($(skip-makefile),)
>
> -srctree		:= $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR))
> -objtree		:= $(CURDIR)
> +srctree		:= $(realpath $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR)))
> +objtree		:= $(realpath $(CURDIR))
>   src		:= $(srctree)
>   obj		:= $(objtree)
>
>


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-08 23:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-26 10:06 [PATCH] Use realpath for srctree and objtree Wang Nan
2014-01-26 16:30 ` Jiri Olsa
2014-01-28 17:14 ` Sasha Levin
2014-02-08  1:43 ` [PATCH resend 1/2] liblockdep: " Wang Nan
2014-02-08 23:14   ` Sasha Levin
2014-02-08  1:44 ` [PATCH resend 2/2] tools lib traceevent: " Wang Nan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox