[PATCH 1/2] ACPI / processor: Replace hard-coded "ACPI0007" with ACPI_PROCESSOR_DEVICE_HID

[PATCH 1/2] ACPI / processor: Replace hard-coded "ACPI0007" with ACPI_PROCESSOR_DEVICE_HID

[Hanjun Guo]

Replace "ACPI0007" with ACPI_PROCESSOR_DEVICE_HID to improve code
readability.

Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
---
 drivers/acpi/processor_core.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index a4eea9a..849cfd6 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -390,5 +390,6 @@ void __init acpi_early_processor_set_pdc(void)
 	acpi_walk_namespace(ACPI_TYPE_PROCESSOR, ACPI_ROOT_OBJECT,
 			    ACPI_UINT32_MAX,
 			    early_init_pdc, NULL, NULL, NULL);
-	acpi_get_devices("ACPI0007", early_init_pdc, NULL, NULL);
+	acpi_get_devices(ACPI_PROCESSOR_DEVICE_HID,
+				early_init_pdc, NULL, NULL);
 }
-- 
1.7.9.5

[PATCH 2/2] ACPI / trivial: Fix the return value type of acpi_processor_eval_pdc()

[Hanjun Guo]

The return value type of acpi_processor_eval_pdc() should be
'acpi_status' but defined as 'int', fix it.

Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
---
 drivers/acpi/processor_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index 849cfd6..46583d7 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -323,7 +323,7 @@ static struct acpi_object_list *acpi_processor_alloc_pdc(void)
  * _PDC is required for a BIOS-OS handshake for most of the newer
  * ACPI processor features.
  */
-static int
+static acpi_status
 acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *pdc_in)
 {
 	acpi_status status = AE_OK;
-- 
1.7.9.5

Re: [PATCH 1/2] ACPI / processor: Replace hard-coded "ACPI0007" with ACPI_PROCESSOR_DEVICE_HID

[Rafael J. Wysocki]

On Saturday, February 08, 2014 08:46:25 PM Hanjun Guo wrote:
> Replace "ACPI0007" with ACPI_PROCESSOR_DEVICE_HID to improve code
> readability.
> 
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> ---
>  drivers/acpi/processor_core.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
> index a4eea9a..849cfd6 100644
> --- a/drivers/acpi/processor_core.c
> +++ b/drivers/acpi/processor_core.c
> @@ -390,5 +390,6 @@ void __init acpi_early_processor_set_pdc(void)
>  	acpi_walk_namespace(ACPI_TYPE_PROCESSOR, ACPI_ROOT_OBJECT,
>  			    ACPI_UINT32_MAX,
>  			    early_init_pdc, NULL, NULL, NULL);
> -	acpi_get_devices("ACPI0007", early_init_pdc, NULL, NULL);
> +	acpi_get_devices(ACPI_PROCESSOR_DEVICE_HID,
> +				early_init_pdc, NULL, NULL);

Please don't break this line (I know it will exceed 80 characters).

>  }
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [PATCH 1/2] ACPI / processor: Replace hard-coded "ACPI0007" with ACPI_PROCESSOR_DEVICE_HID

[Hanjun Guo]

On 2014年02月08日 23:03, Rafael J. Wysocki wrote:
> On Saturday, February 08, 2014 08:46:25 PM Hanjun Guo wrote:
>> Replace "ACPI0007" with ACPI_PROCESSOR_DEVICE_HID to improve code
>> readability.
>>
>> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
>> ---
>>   drivers/acpi/processor_core.c |    3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
>> index a4eea9a..849cfd6 100644
>> --- a/drivers/acpi/processor_core.c
>> +++ b/drivers/acpi/processor_core.c
>> @@ -390,5 +390,6 @@ void __init acpi_early_processor_set_pdc(void)
>>   	acpi_walk_namespace(ACPI_TYPE_PROCESSOR, ACPI_ROOT_OBJECT,
>>   			    ACPI_UINT32_MAX,
>>   			    early_init_pdc, NULL, NULL, NULL);
>> -	acpi_get_devices("ACPI0007", early_init_pdc, NULL, NULL);
>> +	acpi_get_devices(ACPI_PROCESSOR_DEVICE_HID,
>> +				early_init_pdc, NULL, NULL);
> Please don't break this line (I know it will exceed 80 characters).

Ok, I will update this patch.

Thanks
Hanjun