From: Jeff Mahoney <jeffm@suse.com>
To: Rashika Kheria <rashika.kheria@gmail.com>, linux-kernel@vger.kernel.org
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Alex Elder <alex.elder@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Ionut-Gabriel Radu <ihonius@gmail.com>,
reiserfs-devel@vger.kernel.org, josh@joshtriplett.org
Subject: Re: [PATCH 20/21] fs: Move prototype declaration to header file reiserfs.h from super.c
Date: Sun, 09 Feb 2014 13:08:50 -0500 [thread overview]
Message-ID: <52F7C432.8080905@suse.com> (raw)
In-Reply-To: <764a2eddc09cb8670d757cd4170d44d41b3971e0.1391949868.git.rashika.kheria@gmail.com>
On 02/09/2014 08:29 AM, Rashika Kheria wrote:
> Move prototype declaration to header file reiserfs/reiserfs.h from
> reiserfs/super.c because they are used by more than one file.
>
> This eliminates the following warning in reiserfs/bitmap.c:
> fs/reiserfs/bitmap.c:647:6: warning: no previous prototype for ‘show_alloc_options’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Acked-by: Jeff Mahoney <jeffm@suse.com>
> ---
> fs/reiserfs/reiserfs.h | 1 +
> fs/reiserfs/super.c | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/reiserfs/reiserfs.h b/fs/reiserfs/reiserfs.h
> index 8d06adf..83d4eac 100644
> --- a/fs/reiserfs/reiserfs.h
> +++ b/fs/reiserfs/reiserfs.h
> @@ -2831,6 +2831,7 @@ void reiserfs_init_alloc_options(struct super_block *s);
> */
> __le32 reiserfs_choose_packing(struct inode *dir);
>
> +void show_alloc_options(struct seq_file *seq, struct super_block *s);
> int reiserfs_init_bitmap_cache(struct super_block *sb);
> void reiserfs_free_bitmap_cache(struct super_block *sb);
> void reiserfs_cache_bitmap_metadata(struct super_block *sb, struct buffer_head *bh, struct reiserfs_bitmap_info *info);
> diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
> index 2c80335..16d5335 100644
> --- a/fs/reiserfs/super.c
> +++ b/fs/reiserfs/super.c
> @@ -62,7 +62,6 @@ static int is_any_reiserfs_magic_string(struct reiserfs_super_block *rs)
>
> static int reiserfs_remount(struct super_block *s, int *flags, char *data);
> static int reiserfs_statfs(struct dentry *dentry, struct kstatfs *buf);
> -void show_alloc_options(struct seq_file *seq, struct super_block *s);
>
> static int reiserfs_sync_fs(struct super_block *s, int wait)
> {
>
--
Jeff Mahoney
SUSE Labs
next prev parent reply other threads:[~2014-02-09 18:09 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 12:46 [PATCH 01/21] fs: Remove unused function in afs/write.c Rashika Kheria
2014-02-09 12:49 ` [PATCH 02/21] fs: Include appropriate header file in dlm/ast.c Rashika Kheria
2014-02-09 13:04 ` Josh Triplett
2014-02-09 12:52 ` [PATCH 03/21] fs: Mark function as static in fs/bio-integrity.c Rashika Kheria
2014-02-09 13:05 ` Josh Triplett
2014-02-09 20:56 ` Jens Axboe
2014-02-09 13:00 ` [PATCH 04/21] fs: Add prototype declaration to appropriate header file include/linux/bio.h Rashika Kheria
2014-02-09 13:05 ` Josh Triplett
2014-02-09 13:01 ` [PATCH 05/21] fs: Mark function as static in exofs/super.c Rashika Kheria
2014-02-13 17:58 ` Boaz Harrosh
2014-02-13 18:01 ` Rashika Kheria
2014-02-09 13:03 ` [PATCH 06/21] fs: Mark functions as static in exofs/ore_raid.c Rashika Kheria
2014-02-09 13:04 ` [PATCH 07/21] fs: Mark function as static in ext2/xattr_security.c Rashika Kheria
2014-02-11 20:48 ` Jan Kara
2014-02-09 13:06 ` [PATCH 08/21] fs: Mark function as static in ext3/dir.c Rashika Kheria
2014-02-11 20:49 ` Jan Kara
2014-02-09 13:09 ` [PATCH 09/21] fs: Mark function as static in ext3/xattr_security.c Rashika Kheria
2014-02-11 20:49 ` Jan Kara
2014-02-09 13:10 ` [PATCH 10/21] fs: Mark functions as static in gfs2/rgrp.c Rashika Kheria
2014-02-10 12:30 ` Steven Whitehouse
2014-02-09 13:11 ` [PATCH 11/21] fs: Mark functions as static in jbd2/journal.c Rashika Kheria
2014-02-10 2:59 ` Darrick J. Wong
2014-02-12 17:36 ` Theodore Ts'o
2014-02-09 13:12 ` [PATCH 12/21] fs: Include appropriate header file in notify/fdinfo.c Rashika Kheria
2014-02-09 13:14 ` [PATCH 13/21] fs: Mark functions as static in ocfs2/ioctl.c Rashika Kheria
2014-02-09 13:15 ` [PATCH 14/21] fs: Mark functions as static in ocfs2/journal.c Rashika Kheria
2014-02-09 13:16 ` [PATCH 15/21] fs: Mark function as static in ocfs2/xattr.c Rashika Kheria
2014-02-09 13:17 ` [PATCH 16/21] fs: Mark function as static in ocfs2/cluster/heartbeat.c Rashika Kheria
2014-02-09 13:18 ` [PATCH 17/21] fs: Mark function as static in proc/array.c Rashika Kheria
2014-02-09 13:19 ` [PATCH 18/21] fs: Include appropriate header file in proc/proc_tty.c Rashika Kheria
2014-02-09 13:28 ` [PATCH 19/21] fs: Add prototype declaration to header file include/linux/syscalls.h Rashika Kheria
2014-02-10 4:02 ` Josh Triplett
2014-02-11 22:44 ` Andrew Morton
2014-02-09 13:29 ` [PATCH 20/21] fs: Move prototype declaration to header file reiserfs.h from super.c Rashika Kheria
2014-02-09 13:33 ` [PATCH 21/21] fs: Move prototype declaration to appropriate header file Rashika Kheria
2014-02-11 22:36 ` Andrew Morton
2014-02-09 18:08 ` Jeff Mahoney [this message]
2014-02-13 16:06 ` [PATCH 01/21] fs: Remove unused function in afs/write.c David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F7C432.8080905@suse.com \
--to=jeffm@suse.com \
--cc=akpm@linux-foundation.org \
--cc=alex.elder@linaro.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=ihonius@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox