public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: <linux-kernel@vger.kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	<xen-devel@lists.xenproject.org>, <josh@joshtriplett.org>
Subject: Re: [PATCH 1/4] drivers: xen: Mark function as static in platform-pci.c
Date: Mon, 10 Feb 2014 10:31:20 +0000	[thread overview]
Message-ID: <52F8AA78.80805@citrix.com> (raw)
In-Reply-To: <3826f170dae13e3ee700ad9e26a8c88be4b7aaa2.1391943416.git.rashika.kheria@gmail.com>

On 09/02/14 10:59, Rashika Kheria wrote:
> Mark function as static in xen/platform-pci.c because it is not used
> outside this file.
> 
> This eliminates the following warning in xen/platform-pci.c:
> drivers/xen/platform-pci.c:48:15: warning: no previous prototype for ‘alloc_xen_mmio’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

Reviewed-by: David Vrabel <david,vrabel@citrix.com>

David

      parent reply	other threads:[~2014-02-10 10:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-09 10:59 [PATCH 1/4] drivers: xen: Mark function as static in platform-pci.c Rashika Kheria
2014-02-09 11:01 ` [PATCH 2/4] drivers: xen: Include appropriate header file in pcpu.c Rashika Kheria
2014-02-10 11:23   ` David Vrabel
2014-02-09 11:08 ` [PATCH 3/4] drivers: xen: Move prototype declaration to appropriate header file from arch/x86/xen/xen-ops.h Rashika Kheria
2014-02-10 10:32   ` David Vrabel
2014-02-09 11:12 ` [PATCH 4/4] drivers: xen: Move prototype declaration to header file include/xen/xen-ops.h " Rashika Kheria
2014-02-09 12:20   ` Josh Triplett
2014-02-10 11:25   ` David Vrabel
2014-02-10 13:26   ` Stefano Stabellini
2014-02-10 10:31 ` David Vrabel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F8AA78.80805@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=josh@joshtriplett.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rashika.kheria@gmail.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox