From: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org,
fweisbec@gmail.com, mingo@redhat.com
Subject: Re: [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.
Date: Tue, 11 Feb 2014 11:19:27 +0800 [thread overview]
Message-ID: <52F996BF.402@cn.fujitsu.com> (raw)
In-Reply-To: <1390430505-17234-1-git-send-email-yangds.fnst@cn.fujitsu.com>
Hi Steve,
As my patch to implement task_nice() as inline function was applied
to tip tree.
http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=d0ea026808ad81de2af14938448419a95211b938
Please consider to apply this patch in this thread. Thanx :)
On 01/23/2014 06:41 AM, Dongsheng Yang wrote:
> There is already a function named task_nice in sched.h to get the nice value
> of task_struct. We can use it in __update_max_tr() rather than calculate it
> manually.
>
> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
> ---
> kernel/trace/trace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 9d20cd9..ec149b4 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -970,7 +970,7 @@ __update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu)
> else
> max_data->uid = task_uid(tsk);
>
> - max_data->nice = tsk->static_prio - 20 - MAX_RT_PRIO;
> + max_data->nice = task_nice(tsk);
> max_data->policy = tsk->policy;
> max_data->rt_priority = tsk->rt_priority;
>
prev parent reply other threads:[~2014-02-11 3:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 22:41 [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task Dongsheng Yang
2014-01-23 3:56 ` Steven Rostedt
2014-01-23 4:00 ` Steven Rostedt
2014-01-23 17:11 ` Dongsheng Yang
2014-01-23 8:26 ` Peter Zijlstra
2014-01-23 11:52 ` Steven Rostedt
2014-01-27 22:15 ` [PATCH 0/3] sched: Collect the bits about priority into a new header file, include/linux/sched/prio.h Dongsheng Yang
2014-01-27 15:45 ` Steven Rostedt
[not found] ` <CA+qeAOqW58894hGvCP0N0E-EUESfFPeqMmXUuhqxEZrRjDV97A@mail.gmail.com>
2014-01-28 16:06 ` Steven Rostedt
2014-01-27 22:15 ` [PATCH 1/3] sched: Move the priority specific bits into a new header file Dongsheng Yang
2014-01-29 5:28 ` Namhyung Kim
2014-02-10 2:56 ` Dongsheng Yang
2014-02-10 14:09 ` Steven Rostedt
2014-02-11 1:10 ` Dongsheng Yang
2014-02-10 13:30 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-01-27 22:15 ` [PATCH 2/3] sched: Expose some macros related with priority Dongsheng Yang
2014-02-10 13:30 ` [tip:sched/core] sched: Expose some macros related to priority tip-bot for Dongsheng Yang
2014-01-27 22:15 ` [PATCH 3/3] sched: Implement task_nice and task_prio as static inline functions Dongsheng Yang
2014-01-27 10:32 ` Peter Zijlstra
2014-01-28 1:09 ` Dongsheng Yang
2014-01-27 12:16 ` Peter Zijlstra
2014-01-28 1:59 ` Dongsheng Yang
2014-01-27 13:08 ` Peter Zijlstra
2014-01-28 3:00 ` [PATCH 3/3 V2] sched: Implement task_nice as static inline function Dongsheng Yang
2014-01-28 3:27 ` Dongsheng Yang
2014-02-10 13:32 ` [tip:sched/core] sched: Implement task_nice() " tip-bot for Dongsheng Yang
2014-01-23 21:43 ` [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task Dongsheng Yang
2014-02-11 3:19 ` Dongsheng Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F996BF.402@cn.fujitsu.com \
--to=yangds.fnst@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox