From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751756AbaBKOlk (ORCPT ); Tue, 11 Feb 2014 09:41:40 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:55251 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812AbaBKOlj (ORCPT ); Tue, 11 Feb 2014 09:41:39 -0500 Message-ID: <52FA3686.5080800@ti.com> Date: Tue, 11 Feb 2014 08:41:10 -0600 From: Nishanth Menon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Hans de Goede , Roger Quadros , CC: , , , , , Subject: Re: [PATCH] ARM: dts: OMAP2+: Fix boot with multi_v7_defconfig References: <1392055835-6494-1-git-send-email-rogerq@ti.com> <52FA2B4F.3010408@ti.com> <52FA3102.7080407@ti.com> <52FA3531.8090308@redhat.com> In-Reply-To: <52FA3531.8090308@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2014 08:35 AM, Hans de Goede wrote: > On 02/11/2014 03:17 PM, Nishanth Menon wrote: >> On 02/11/2014 07:53 AM, Roger Quadros wrote: >>> On 02/10/2014 08:10 PM, Roger Quadros wrote: >>>> The OMAP EHCI controller is not compatible with the EHCI >>>> platform HCD driver so don't claim that we are. >>>> >>>> This fixes boot on OMAP platforms with CONFIG_USB_EHCI_HCD_PLATFORM=y >>>> e.g. multi_v7_defconfig >>>> >>>> Reported-by: Nishanth Menon >>>> Signed-off-by: Roger Quadros >>> >>> Please ignore this patch as Hans has agreed to do a more proper fix in >>> >>> http://article.gmane.org/gmane.comp.hardware.netbook.arm.sunxi/7015 >> umm.. even then, drivers/usb/host/ehci-ppc-of.c claims compatibility >> with usb,ehci -> and we wont function with that driver either. > > Right, but that has never been an issue as no kernel will ever include > both ppc and omap support. Conceptually, we have compatibility string today in dts description that maps a driver that cant ever handle the device. I dont have strong opinions either way.. just something i noticed with a git grep.. -- Regards, Nishanth Menon