From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Cc: mingo@kernel.org, peterz@infradead.org, tglx@linutronix.de,
rjw@rjwysocki.net, nicolas.pitre@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] cpuidle/idle: Move the cpuidle_idle_call function to idle.c
Date: Wed, 12 Feb 2014 13:35:15 +0100 [thread overview]
Message-ID: <52FB6A83.9080800@linaro.org> (raw)
In-Reply-To: <52FB5061.1000709@linux.vnet.ibm.com>
On 02/12/2014 11:43 AM, Preeti U Murthy wrote:
> Hi Daniel,
>
> On 02/11/2014 08:41 PM, Daniel Lezcano wrote:
>> The cpuidle_idle_call does nothing more than calling the three individuals
>> function and is no longer used by any arch specific code but only in the
>> cpuidle framework code.
>>
>> We can move this function into the idle task code to ensure better
>> proximity to the scheduler code.
>
> So my understanding of this patchset is that by moving
> cpuidle_idle_call() under kernel/sched, we now have a way of calling
> into the cpuidle governor and the cpuidle driver with additional
> parameters like cpu_load(), idle_stamp etc.. so that we can expect the
> governor and driver to take better decisions about entry and exit into
> idle states. Is this the advantage we hope to begin with?
Yes, right.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2014-02-12 12:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 15:11 [PATCH 1/5] idle/cpuidle: Split cpuidle_idle_call main function into smaller functions Daniel Lezcano
2014-02-11 15:11 ` [PATCH 2/5] cpuidle/idle: Move the cpuidle_idle_call function to idle.c Daniel Lezcano
2014-02-12 10:43 ` Preeti U Murthy
2014-02-12 12:35 ` Daniel Lezcano [this message]
2014-02-11 15:11 ` [PATCH 3/5] idle: Reorganize the idle loop Daniel Lezcano
2014-02-11 17:36 ` Nicolas Pitre
2014-02-12 11:00 ` Preeti U Murthy
2014-02-12 12:45 ` Daniel Lezcano
2014-02-11 15:11 ` [PATCH 4/5] idle: Move idle conditions in cpuidle_idle main function Daniel Lezcano
2014-02-11 15:11 ` [PATCH 5/5] idle: Add more comments to the code Daniel Lezcano
2014-02-11 17:51 ` Nicolas Pitre
2014-02-11 21:52 ` Daniel Lezcano
2014-02-11 17:27 ` [PATCH 1/5] idle/cpuidle: Split cpuidle_idle_call main function into smaller functions Nicolas Pitre
2014-02-12 10:38 ` Preeti U Murthy
2014-02-12 12:37 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FB6A83.9080800@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=peterz@infradead.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).