From: "H. Peter Anvin" <hpa@zytor.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: David Rientjes <rientjes@google.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org
Subject: Re: [PATCH] x86: fix two sparse warnings in early boot string handling
Date: Thu, 13 Feb 2014 06:01:03 -0800 [thread overview]
Message-ID: <52FCD01F.70500@zytor.com> (raw)
In-Reply-To: <20140213103109.GB20717@console-pimps.org>
On 02/13/2014 02:31 AM, Matt Fleming wrote:
> On Wed, 12 Feb, at 03:31:05PM, H. Peter Anvin wrote:
>>
>> The real answer IMO ought to be that since arch/x86/boot/string.c is now
>> used separately from boot.h (eboot.c which includes efi-stub-helper.c
>> does *not* include boot.h) we may have to move those string functions
>> into a separate header file.
>>
>> Matt, do you have any opinions here?
>
> This makes sense to me. Perhaps arch/x86/boot/lib/string.c which would
> be useable by both arch/x86/boot/*.c and arch/x86/boot/compressed/*.c?
>
That would be fine, but the issue at hand isn't the .c file but the lack
of a corresponding .h file...
-hpa
prev parent reply other threads:[~2014-02-13 14:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 18:33 [PATCH] x86: fix two sparse warnings in early boot string handling Paul Gortmaker
2014-02-11 22:26 ` David Rientjes
2014-02-12 2:00 ` Paul Gortmaker
2014-02-12 2:23 ` David Rientjes
2014-02-12 14:57 ` Paul Gortmaker
2014-02-12 15:49 ` Paul Gortmaker
2014-02-12 22:00 ` David Rientjes
2014-02-12 22:29 ` Paul Gortmaker
2014-02-12 23:14 ` David Rientjes
2014-02-12 23:31 ` H. Peter Anvin
2014-02-13 10:31 ` Matt Fleming
2014-02-13 14:01 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FCD01F.70500@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox