From: Stephen Warren <swarren@wwwdotorg.org>
To: Tomasz Figa <t.figa@samsung.com>,
Alexandre Courbot <acourbot@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
Russell King <linux@arm.linux.org.uk>
Cc: Olof Johansson <olof@lixom.net>,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
gnurou@gmail.com
Subject: Re: [PATCH v2 4/6] ARM: firmware: add prepare_idle() operation
Date: Thu, 13 Feb 2014 09:37:05 -0700 [thread overview]
Message-ID: <52FCF4B1.5030208@wwwdotorg.org> (raw)
In-Reply-To: <52FCA5FC.80504@samsung.com>
On 02/13/2014 04:01 AM, Tomasz Figa wrote:
> Hi Alexandre,
>
> On 07.02.2014 05:35, Alexandre Courbot wrote:
>> Some firmwares do not put the CPU into idle mode themselves, but still
>> need to be informed that the CPU is about to enter idle mode before this
>> happens. Add a prepare_idle() operation to the firmware_ops structure to
>> handle such cases.
>>
>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>> ---
>> arch/arm/include/asm/firmware.h | 4 ++++
>> 1 file changed, 4 insertions(+)
>
> I wonder if .do_idle() couldn't simply return an appropriate error code
> to let the upper layer know that it should proceed with normal CPU idle
> activation, while still letting the firmware know that the CPU is going
> to idle.
That seems to disagree with the naming of the operation, and the
semantics I assume it has, though. It seems clearer to add an explicit
separate op for this.
next prev parent reply other threads:[~2014-02-13 16:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 4:35 [PATCH v2 0/6] ARM: firmware: improvements to Trusted Foundations support Alexandre Courbot
2014-02-07 4:35 ` [PATCH v2 1/6] ARM: trusted_foundations: fix vendor prefix typos Alexandre Courbot
2014-02-07 4:35 ` [PATCH v2 2/6] ARM: trusted_foundations: fallback when TF support is missing Alexandre Courbot
2014-02-07 4:35 ` [PATCH v2 3/6] ARM: firmware: enable Trusted Foundations by default Alexandre Courbot
2014-02-07 4:35 ` [PATCH v2 4/6] ARM: firmware: add prepare_idle() operation Alexandre Courbot
2014-02-13 11:01 ` Tomasz Figa
2014-02-13 16:37 ` Stephen Warren [this message]
2014-02-14 5:16 ` Alexandre Courbot
2014-02-14 10:42 ` Tomasz Figa
2014-02-07 4:35 ` [PATCH v2 5/6] ARM: trusted_foundations: implement prepare_idle() Alexandre Courbot
2014-02-07 4:35 ` [PATCH v2 6/6] ARM: tegra: cpuidle: use firmware for power down Alexandre Courbot
2014-02-12 1:36 ` Olof Johansson
2014-02-12 1:56 ` Alexandre Courbot
2014-02-12 2:43 ` [PATCH v3] " Alexandre Courbot
2014-02-12 20:04 ` Olof Johansson
2014-02-12 1:38 ` [PATCH v2 0/6] ARM: firmware: improvements to Trusted Foundations support Olof Johansson
2014-02-12 20:07 ` Stephen Warren
2014-02-18 20:56 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FCF4B1.5030208@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=acourbot@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=t.figa@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox