From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: <akpm@linux-foundation.org>, <toshi.kani@hp.com>,
<rientjes@google.com>, <gong.chen@linux.intel.com>,
<haokexin@gmail.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/resource.c: fix sparse non static symbol warning
Date: Fri, 14 Feb 2014 08:27:44 +0900 [thread overview]
Message-ID: <52FD54F0.8050006@jp.fujitsu.com> (raw)
In-Reply-To: <2767883.6dX08SOjIi@daeseok-laptop.cloud.net>
(2014/02/13 11:02), Daeseok Youn wrote:
> From f8e0752ac80e56bcbfe197a5820692d199822b52 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Thu, 13 Feb 2014 10:11:39 +0900
> Subject: [PATCH] kernel/resource.c: fix sparse non static symbol warning
>
> kernel/resource.c:518:5: warning:
> symbol 'reallocate_resource' was not declared. Should it be static?
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Thanks,
Yasuaki Ishimatsu
> kernel/resource.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/resource.c b/kernel/resource.c
> index 3f285dc..b2979c6 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -515,7 +515,7 @@ static int find_resource(struct resource *root, struct resource *new,
> * @newsize: new size of the resource descriptor
> * @constraint: the size and alignment constraints to be met.
> */
> -int reallocate_resource(struct resource *root, struct resource *old,
> +static int reallocate_resource(struct resource *root, struct resource *old,
> resource_size_t newsize,
> struct resource_constraint *constraint)
> {
>
prev parent reply other threads:[~2014-02-13 23:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 2:02 [PATCH] kernel/resource.c: fix sparse non static symbol warning Daeseok Youn
2014-02-13 2:28 ` David Rientjes
2014-02-13 6:20 ` DaeSeok Youn
2014-02-13 23:27 ` Yasuaki Ishimatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FD54F0.8050006@jp.fujitsu.com \
--to=isimatu.yasuaki@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=daeseok.youn@gmail.com \
--cc=gong.chen@linux.intel.com \
--cc=haokexin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=toshi.kani@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox