* [PATCH] kernel/resource.c: fix sparse non static symbol warning
@ 2014-02-13 2:02 Daeseok Youn
2014-02-13 2:28 ` David Rientjes
2014-02-13 23:27 ` Yasuaki Ishimatsu
0 siblings, 2 replies; 4+ messages in thread
From: Daeseok Youn @ 2014-02-13 2:02 UTC (permalink / raw)
To: akpm
Cc: toshi.kani, isimatu.yasuaki, rientjes, gong.chen, haokexin,
linux-kernel
>From f8e0752ac80e56bcbfe197a5820692d199822b52 Mon Sep 17 00:00:00 2001
From: Daeseok Youn <daeseok.youn@gmail.com>
Date: Thu, 13 Feb 2014 10:11:39 +0900
Subject: [PATCH] kernel/resource.c: fix sparse non static symbol warning
kernel/resource.c:518:5: warning:
symbol 'reallocate_resource' was not declared. Should it be static?
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
kernel/resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/resource.c b/kernel/resource.c
index 3f285dc..b2979c6 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -515,7 +515,7 @@ static int find_resource(struct resource *root, struct resource *new,
* @newsize: new size of the resource descriptor
* @constraint: the size and alignment constraints to be met.
*/
-int reallocate_resource(struct resource *root, struct resource *old,
+static int reallocate_resource(struct resource *root, struct resource *old,
resource_size_t newsize,
struct resource_constraint *constraint)
{
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] kernel/resource.c: fix sparse non static symbol warning
2014-02-13 2:02 [PATCH] kernel/resource.c: fix sparse non static symbol warning Daeseok Youn
@ 2014-02-13 2:28 ` David Rientjes
2014-02-13 6:20 ` DaeSeok Youn
2014-02-13 23:27 ` Yasuaki Ishimatsu
1 sibling, 1 reply; 4+ messages in thread
From: David Rientjes @ 2014-02-13 2:28 UTC (permalink / raw)
To: Daeseok Youn
Cc: Andrew Morton, toshi.kani, isimatu.yasuaki, gong.chen, haokexin,
linux-kernel
On Thu, 13 Feb 2014, Daeseok Youn wrote:
> From f8e0752ac80e56bcbfe197a5820692d199822b52 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Thu, 13 Feb 2014 10:11:39 +0900
> Subject: [PATCH] kernel/resource.c: fix sparse non static symbol warning
>
> kernel/resource.c:518:5: warning:
> symbol 'reallocate_resource' was not declared. Should it be static?
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Changelog would be better if it said it's only referenced in file scope so
it can be marked static.
Acked-by: David Rientjes <rientjes@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kernel/resource.c: fix sparse non static symbol warning
2014-02-13 2:28 ` David Rientjes
@ 2014-02-13 6:20 ` DaeSeok Youn
0 siblings, 0 replies; 4+ messages in thread
From: DaeSeok Youn @ 2014-02-13 6:20 UTC (permalink / raw)
To: David Rientjes
Cc: Andrew Morton, toshi.kani, isimatu.yasuaki, gong.chen, Kevin Hao,
linux-kernel
OK. If I send a patch like this again, ChangeLog is written as you comment.
Thanks.
Daeseok Youn.
2014-02-13 11:28 GMT+09:00 David Rientjes <rientjes@google.com>:
> On Thu, 13 Feb 2014, Daeseok Youn wrote:
>
>> From f8e0752ac80e56bcbfe197a5820692d199822b52 Mon Sep 17 00:00:00 2001
>> From: Daeseok Youn <daeseok.youn@gmail.com>
>> Date: Thu, 13 Feb 2014 10:11:39 +0900
>> Subject: [PATCH] kernel/resource.c: fix sparse non static symbol warning
>>
>> kernel/resource.c:518:5: warning:
>> symbol 'reallocate_resource' was not declared. Should it be static?
>>
>> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
>
> Changelog would be better if it said it's only referenced in file scope so
> it can be marked static.
>
> Acked-by: David Rientjes <rientjes@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kernel/resource.c: fix sparse non static symbol warning
2014-02-13 2:02 [PATCH] kernel/resource.c: fix sparse non static symbol warning Daeseok Youn
2014-02-13 2:28 ` David Rientjes
@ 2014-02-13 23:27 ` Yasuaki Ishimatsu
1 sibling, 0 replies; 4+ messages in thread
From: Yasuaki Ishimatsu @ 2014-02-13 23:27 UTC (permalink / raw)
To: Daeseok Youn
Cc: akpm, toshi.kani, rientjes, gong.chen, haokexin, linux-kernel
(2014/02/13 11:02), Daeseok Youn wrote:
> From f8e0752ac80e56bcbfe197a5820692d199822b52 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Thu, 13 Feb 2014 10:11:39 +0900
> Subject: [PATCH] kernel/resource.c: fix sparse non static symbol warning
>
> kernel/resource.c:518:5: warning:
> symbol 'reallocate_resource' was not declared. Should it be static?
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Thanks,
Yasuaki Ishimatsu
> kernel/resource.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/resource.c b/kernel/resource.c
> index 3f285dc..b2979c6 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -515,7 +515,7 @@ static int find_resource(struct resource *root, struct resource *new,
> * @newsize: new size of the resource descriptor
> * @constraint: the size and alignment constraints to be met.
> */
> -int reallocate_resource(struct resource *root, struct resource *old,
> +static int reallocate_resource(struct resource *root, struct resource *old,
> resource_size_t newsize,
> struct resource_constraint *constraint)
> {
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-13 23:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-13 2:02 [PATCH] kernel/resource.c: fix sparse non static symbol warning Daeseok Youn
2014-02-13 2:28 ` David Rientjes
2014-02-13 6:20 ` DaeSeok Youn
2014-02-13 23:27 ` Yasuaki Ishimatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox