From: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 0/9] Add MAX_NICE, MIN_NICE and NICE_WIDTH macros in prio.h.
Date: Fri, 14 Feb 2014 17:22:50 +0800 [thread overview]
Message-ID: <52FDE06A.1020909@cn.fujitsu.com> (raw)
In-Reply-To: <cover.1392103744.git.yangds.fnst@cn.fujitsu.com>
Hi Ingo & Peter,
What's your opinion on this patchset?
On 02/11/2014 03:34 PM, Dongsheng Yang wrote:
> Hi Peter,
> There are lots of hardcoding of -20 and 19 in kernel to represent
> minimum and maximum of nice value currently. This patch set define three
> macros in prio.h and replace some of the hardcoding with them.
>
> Please help to take a look at it, thanx :)
>
> Dongsheng Yang (9):
> sched: Prio: Use DEFAULT_PRIO to define NICE_TO_PRIO and PRIO_TO_NICE.
> sched: prio: Add 3 macros of MAX_NICE, MIN_NICE and NICE_WIDTH in
> prio.h.
> sched: prio: Use NICE_WIDTH macro to avoid using of hard coding of 40
> and 20 in prio.h.
> sched: prio: Add spaces before and after operator of '-'.
> rcu: Use MAX_NICE to replace hard coding of 19.
> sched: Replace hardcoding of -20 and 19 with MIN_NICE and MAX_NICE.
> sys: Replace hardcoding of -20 and 19 with MIN_NICE and MAX_NICE.
> workqueue: Replace hardcoding of -20 and 19 with MIN_NICE and
> MAX_NICE.
> trace: Replace hardcoding of 19 with MAX_NICE.
>
> include/linux/sched/prio.h | 14 +++++++++-----
> kernel/rcu/torture.c | 8 ++++----
> kernel/sched/auto_group.c | 2 +-
> kernel/sched/core.c | 12 ++++++------
> kernel/sys.c | 8 ++++----
> kernel/trace/ring_buffer_benchmark.c | 6 +++---
> kernel/workqueue.c | 2 +-
> 7 files changed, 28 insertions(+), 24 deletions(-)
>
next prev parent reply other threads:[~2014-02-14 9:23 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 7:34 [PATCH 0/9] Add MAX_NICE, MIN_NICE and NICE_WIDTH macros in prio.h Dongsheng Yang
2014-02-11 7:34 ` [PATCH 1/9] sched: Prio: Use DEFAULT_PRIO to define NICE_TO_PRIO and PRIO_TO_NICE Dongsheng Yang
2014-02-21 21:32 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-22 18:03 ` [tip:sched/core] sched/prio: Use DEFAULT_PRIO to define NICE_TO_PRIO() and PRIO_TO_NICE() tip-bot for Dongsheng Yang
2014-02-11 7:34 ` [PATCH 2/9] sched: prio: Add 3 macros of MAX_NICE, MIN_NICE and NICE_WIDTH in prio.h Dongsheng Yang
2014-02-21 21:33 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-22 18:03 ` [tip:sched/core] sched/prio: " tip-bot for Dongsheng Yang
2014-02-11 7:34 ` [PATCH 3/9] sched: prio: Use NICE_WIDTH macro to avoid using of hard coding of 40 and 20 " Dongsheng Yang
2014-02-21 21:33 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-11 7:34 ` [PATCH 4/9] sched: prio: Add spaces before and after operator of '-' Dongsheng Yang
2014-02-21 21:33 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-11 7:34 ` [PATCH 5/9] rcu: Use MAX_NICE to replace hard coding of 19 Dongsheng Yang
2014-02-11 15:37 ` Josh Triplett
2014-02-11 16:13 ` Paul E. McKenney
2014-02-11 16:42 ` Peter Zijlstra
2014-02-11 17:42 ` Paul E. McKenney
2014-02-21 21:33 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-22 18:03 ` [tip:sched/core] rcu: Use MAX_NICE to replace hardcoding " tip-bot for Dongsheng Yang
2014-02-11 7:34 ` [PATCH 6/9] sched: Replace hardcoding of -20 and 19 with MIN_NICE and MAX_NICE Dongsheng Yang
2014-02-21 21:33 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-22 18:03 ` tip-bot for Dongsheng Yang
2014-02-11 7:34 ` [PATCH 7/9] sys: " Dongsheng Yang
2014-02-11 18:27 ` Kees Cook
2014-02-12 3:59 ` Dongsheng Yang
2014-02-12 6:40 ` Kees Cook
2014-02-21 21:34 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-22 18:04 ` tip-bot for Dongsheng Yang
2014-02-11 7:34 ` [PATCH 8/9] workqueue: " Dongsheng Yang
2014-02-11 17:50 ` Tejun Heo
2014-02-21 21:34 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-22 18:04 ` tip-bot for Dongsheng Yang
2014-02-11 7:34 ` [PATCH 9/9] trace: Replace hardcoding of 19 with MAX_NICE Dongsheng Yang
2014-02-22 9:05 ` Dongsheng Yang
2014-02-22 9:27 ` Peter Zijlstra
2014-02-24 10:46 ` Peter Zijlstra
2014-02-24 14:08 ` Dongsheng Yang
2014-02-24 14:12 ` [PATCH Resend] " Dongsheng Yang
2014-02-24 14:22 ` Peter Zijlstra
2014-02-24 14:29 ` Steven Rostedt
2014-02-24 14:48 ` Peter Zijlstra
2014-02-27 13:33 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-14 9:22 ` Dongsheng Yang [this message]
2014-02-14 9:51 ` [PATCH 0/9] Add MAX_NICE, MIN_NICE and NICE_WIDTH macros in prio.h Peter Zijlstra
2014-02-14 9:54 ` Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FDE06A.1020909@cn.fujitsu.com \
--to=yangds.fnst@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox