Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

[Jeff Chua]

Can't suspend to ram/disk on the Lenovo X240 with Intel i7-4600.

kernel 3.14.0-rc2

The same kernel works find on Lenovo X230 with Intel i7-3520M.

Here's the trace ..


[<ffffffff81034ba6>] ? do_exit+0x852/0x89d
[<ffffffff8158e5d8>] ? prinfk+0x4f/0x54
[<iiffffff81005060>] ? oops_end+0x78/0x7d
[<ffffffff8158dc00>] ? no_context+0x1e6/0x1f5
[<ffffffff810274f8>] ? __do_page_fault+0x348/0x3c7
[<ffffffff8159376a>] ? __schedule+0x6Z3/0x775
[<ffffffff81596562>] ? page_fault+0x2Z/8x30
[<ffffffff814e76e4>] ? azx_enter_link_reset.isra.26+0x9/0x51
[<ffffffff814e68ac>] ? azx_clear_irq_pending+0x12/0x3e
[<ffffffff814e7821>1 ? azx_suspend+0xa1/0x105
[<ffffffff8128f543>] ? pci_pm_suspend+0x6e/0xee
[<ffffffff8128f4d5>] ? pci_pm_poweroff+0xb4/0xb4
[<ffffffff81333479>] ? dpm_run_callback.isra.8+0x24/8x52
[<ffffffff813335df>] ? __device_suspend+8x138/0x19b
[<ffffffff81333658>] ? async_suspend+0x16/0x7d
[<ffffffff8104d743>] ? async_run_entry_fn+0x55/0x10b
[<ffffffff81044abf>] ? process_one_work+0x1be/0x2ef
[<ffffffff8104503d>] ? worker_thread+0x1cb/0x2c4
[<ffffffff81044e72>] ? rescuer_thread+0x25d/0x25d
[<ffffffff81049a93>] ? kthread+0xc5/0xcd
[<ffffffff81040000>] ? SyS_setpriority+0x179/0x233
[<ffffffff810499ce>l ? kthread_freezable_should_stop+0x3b/0x3b
[<ffffffff8159697c>] ? rat_from_fork+0x7c/0xb0
[<ffffffff810499ce>l ? kthread_freezable_should_stop+0x3b/0x3b


Thanks,
Jeff

Re: Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

[Peter Hurley]

[ +cc Takashi Iwai, Dave Airlie ]

Hi Jeff,

On 02/13/2014 08:02 AM, Jeff Chua wrote:
> Can't suspend to ram/disk on the Lenovo X240 with Intel i7-4600.
>
> kernel 3.14.0-rc2
>
> The same kernel works find on Lenovo X230 with Intel i7-3520M.
>
> Here's the trace ..

Apparently there's no maintainer but I've cc'ed people who might
have a clue about this.

Regards,
Peter Hurley

> [<ffffffff81034ba6>] ? do_exit+0x852/0x89d
> [<ffffffff8158e5d8>] ? prinfk+0x4f/0x54
> [<iiffffff81005060>] ? oops_end+0x78/0x7d
> [<ffffffff8158dc00>] ? no_context+0x1e6/0x1f5
> [<ffffffff810274f8>] ? __do_page_fault+0x348/0x3c7
> [<ffffffff8159376a>] ? __schedule+0x6Z3/0x775
> [<ffffffff81596562>] ? page_fault+0x2Z/8x30
> [<ffffffff814e76e4>] ? azx_enter_link_reset.isra.26+0x9/0x51
> [<ffffffff814e68ac>] ? azx_clear_irq_pending+0x12/0x3e
> [<ffffffff814e7821>1 ? azx_suspend+0xa1/0x105
> [<ffffffff8128f543>] ? pci_pm_suspend+0x6e/0xee
> [<ffffffff8128f4d5>] ? pci_pm_poweroff+0xb4/0xb4
> [<ffffffff81333479>] ? dpm_run_callback.isra.8+0x24/8x52
> [<ffffffff813335df>] ? __device_suspend+8x138/0x19b
> [<ffffffff81333658>] ? async_suspend+0x16/0x7d
> [<ffffffff8104d743>] ? async_run_entry_fn+0x55/0x10b
> [<ffffffff81044abf>] ? process_one_work+0x1be/0x2ef
> [<ffffffff8104503d>] ? worker_thread+0x1cb/0x2c4
> [<ffffffff81044e72>] ? rescuer_thread+0x25d/0x25d
> [<ffffffff81049a93>] ? kthread+0xc5/0xcd
> [<ffffffff81040000>] ? SyS_setpriority+0x179/0x233
> [<ffffffff810499ce>l ? kthread_freezable_should_stop+0x3b/0x3b
> [<ffffffff8159697c>] ? rat_from_fork+0x7c/0xb0
> [<ffffffff810499ce>l ? kthread_freezable_should_stop+0x3b/0x3b

Re: Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

[Takashi Iwai]

At Thu, 13 Feb 2014 12:14:58 -0500,
Peter Hurley wrote:
> 
> [ +cc Takashi Iwai, Dave Airlie ]
> 
> Hi Jeff,
> 
> On 02/13/2014 08:02 AM, Jeff Chua wrote:
> > Can't suspend to ram/disk on the Lenovo X240 with Intel i7-4600.
> >
> > kernel 3.14.0-rc2
> >
> > The same kernel works find on Lenovo X230 with Intel i7-3520M.
> >
> > Here's the trace ..
> 
> Apparently there's no maintainer but I've cc'ed people who might
> have a clue about this.
> 
> Regards,
> Peter Hurley
> 
> > [<ffffffff81034ba6>] ? do_exit+0x852/0x89d
> > [<ffffffff8158e5d8>] ? prinfk+0x4f/0x54
> > [<iiffffff81005060>] ? oops_end+0x78/0x7d
> > [<ffffffff8158dc00>] ? no_context+0x1e6/0x1f5
> > [<ffffffff810274f8>] ? __do_page_fault+0x348/0x3c7
> > [<ffffffff8159376a>] ? __schedule+0x6Z3/0x775
> > [<ffffffff81596562>] ? page_fault+0x2Z/8x30
> > [<ffffffff814e76e4>] ? azx_enter_link_reset.isra.26+0x9/0x51
> > [<ffffffff814e68ac>] ? azx_clear_irq_pending+0x12/0x3e
> > [<ffffffff814e7821>1 ? azx_suspend+0xa1/0x105
> > [<ffffffff8128f543>] ? pci_pm_suspend+0x6e/0xee
> > [<ffffffff8128f4d5>] ? pci_pm_poweroff+0xb4/0xb4
> > [<ffffffff81333479>] ? dpm_run_callback.isra.8+0x24/8x52
> > [<ffffffff813335df>] ? __device_suspend+8x138/0x19b
> > [<ffffffff81333658>] ? async_suspend+0x16/0x7d
> > [<ffffffff8104d743>] ? async_run_entry_fn+0x55/0x10b
> > [<ffffffff81044abf>] ? process_one_work+0x1be/0x2ef
> > [<ffffffff8104503d>] ? worker_thread+0x1cb/0x2c4
> > [<ffffffff81044e72>] ? rescuer_thread+0x25d/0x25d
> > [<ffffffff81049a93>] ? kthread+0xc5/0xcd
> > [<ffffffff81040000>] ? SyS_setpriority+0x179/0x233
> > [<ffffffff810499ce>l ? kthread_freezable_should_stop+0x3b/0x3b
> > [<ffffffff8159697c>] ? rat_from_fork+0x7c/0xb0
> > [<ffffffff810499ce>l ? kthread_freezable_should_stop+0x3b/0x3b

Is it a Intel+Nvidia hybrid?  If so, does it happen even with
CONFIG_VGA_SWITCHEROO=n?


Takashi

Re: Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

[Theodore Ts'o]

For what it's worth, I have a the X240's bigger brother --- a T540p
(with intel graphics and the 3k panel) running 3.14-rc2, and
suspend-to-ram is working without any problems on my laptop.

Cheers,

						- Ted

Re: Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

[Jeff Chua]

On Fri, Feb 14, 2014 at 1:28 AM, Takashi Iwai <tiwai@suse.de> wrote:
> At Thu, 13 Feb 2014 12:14:58 -0500,  Peter Hurley wrote:
> Apparently there's no maintainer but I've cc'ed people who might
> have a clue about this.

Peter ... thanks for pointer.

> On Fri, Feb 14, 2014 at 1:28 AM, Takashi Iwai <tiwai@suse.de> wrote:
> Is it a Intel+Nvidia hybrid?  If so, does it happen even with
> CONFIG_VGA_SWITCHEROO=n?

It's not Intel+Nvidia. It's Intel Core i7-4600U 2.1 GHz, Intel HD Graphics 4400.

I checked my config. CONFIG_VGA_SWITCHEROO is not set.

On Fri, Feb 14, 2014 at 5:21 AM, Theodore Ts'o <tytso@mit.edu> wrote:
> For what it's worth, I have a the X240's bigger brother --- a T540p
> (with intel graphics and the 3k panel) running 3.14-rc2, and
> suspend-to-ram is working without any problems on my laptop.

Interesting. Perhaps it's the USB options. I had these set to "y"

CONFIG_USB_XHCI_HCD=y
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_EHCI_ROOT_HUB_TT=y
CONFIG_USB_EHCI_TT_NEWSCHED=y
CONFIG_USB_EHCI_PCI=y

Again, These same config works find on X230. It's very strange. The
same hard disk (SSD) can suspend-to-ram on the X230 but not on the
X240. The X230 has i7-3520M vs X240 i7-4600U.

I've even tried with all the USB set to "n" and still couldn't S2D.
May be the graphic?

Thanks,
Jeff

Re: Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

[Takashi Iwai]

At Fri, 14 Feb 2014 21:46:25 +0800,
Jeff Chua wrote:
> 
> On Fri, Feb 14, 2014 at 1:28 AM, Takashi Iwai <tiwai@suse.de> wrote:
> > At Thu, 13 Feb 2014 12:14:58 -0500,  Peter Hurley wrote:
> > Apparently there's no maintainer but I've cc'ed people who might
> > have a clue about this.
> 
> Peter ... thanks for pointer.
> 
> > On Fri, Feb 14, 2014 at 1:28 AM, Takashi Iwai <tiwai@suse.de> wrote:
> > Is it a Intel+Nvidia hybrid?  If so, does it happen even with
> > CONFIG_VGA_SWITCHEROO=n?
> 
> It's not Intel+Nvidia. It's Intel Core i7-4600U 2.1 GHz, Intel HD Graphics 4400.

OK.  Then it's a different thing as I expected.

The other possible change in hda_intel.c is the enablement of runtime
PM for Panther Point.  But it's been working for other chips, so
wondering why it hits anything.  In anyway, please give the full
Oops messages not only the stack trace.

> I checked my config. CONFIG_VGA_SWITCHEROO is not set.
> 
> On Fri, Feb 14, 2014 at 5:21 AM, Theodore Ts'o <tytso@mit.edu> wrote:
> > For what it's worth, I have a the X240's bigger brother --- a T540p
> > (with intel graphics and the 3k panel) running 3.14-rc2, and
> > suspend-to-ram is working without any problems on my laptop.
> 
> Interesting. Perhaps it's the USB options. I had these set to "y"
> 
> CONFIG_USB_XHCI_HCD=y
> CONFIG_USB_EHCI_HCD=y
> CONFIG_USB_EHCI_ROOT_HUB_TT=y
> CONFIG_USB_EHCI_TT_NEWSCHED=y
> CONFIG_USB_EHCI_PCI=y
> 
> Again, These same config works find on X230. It's very strange. The
> same hard disk (SSD) can suspend-to-ram on the X230 but not on the
> X240. The X230 has i7-3520M vs X240 i7-4600U.

Any difference in the sound hardware, i.e. PCI controller and codec
chips?

> I've even tried with all the USB set to "n" and still couldn't S2D.

Do you mean S2R?  I thought the bug is about S3?


Takashi

Re: Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

[Peter Hurley]

On 02/14/2014 08:57 AM, Takashi Iwai wrote:
> At Fri, 14 Feb 2014 21:46:25 +0800,
> Jeff Chua wrote:
>>
>> On Fri, Feb 14, 2014 at 1:28 AM, Takashi Iwai <tiwai@suse.de> wrote:
>>> At Thu, 13 Feb 2014 12:14:58 -0500,  Peter Hurley wrote:
>>> Apparently there's no maintainer but I've cc'ed people who might
>>> have a clue about this.
>>
>> Peter ... thanks for pointer.
>>
>>> On Fri, Feb 14, 2014 at 1:28 AM, Takashi Iwai <tiwai@suse.de> wrote:
>>> Is it a Intel+Nvidia hybrid?  If so, does it happen even with
>>> CONFIG_VGA_SWITCHEROO=n?
>>
>> It's not Intel+Nvidia. It's Intel Core i7-4600U 2.1 GHz, Intel HD Graphics 4400.
>
> OK.  Then it's a different thing as I expected.
>
> The other possible change in hda_intel.c is the enablement of runtime
> PM for Panther Point.  But it's been working for other chips, so
> wondering why it hits anything.  In anyway, please give the full
> Oops messages not only the stack trace.

Also, please attach your config and dmesg.

>> I checked my config. CONFIG_VGA_SWITCHEROO is not set.
>>
>> On Fri, Feb 14, 2014 at 5:21 AM, Theodore Ts'o <tytso@mit.edu> wrote:
>>> For what it's worth, I have a the X240's bigger brother --- a T540p
>>> (with intel graphics and the 3k panel) running 3.14-rc2, and
>>> suspend-to-ram is working without any problems on my laptop.
>>
>> Interesting. Perhaps it's the USB options. I had these set to "y"
>>
>> CONFIG_USB_XHCI_HCD=y
>> CONFIG_USB_EHCI_HCD=y
>> CONFIG_USB_EHCI_ROOT_HUB_TT=y
>> CONFIG_USB_EHCI_TT_NEWSCHED=y
>> CONFIG_USB_EHCI_PCI=y
>>
>> Again, These same config works find on X230. It's very strange. The
>> same hard disk (SSD) can suspend-to-ram on the X230 but not on the
>> X240. The X230 has i7-3520M vs X240 i7-4600U.
>
> Any difference in the sound hardware, i.e. PCI controller and codec
> chips?
>
>> I've even tried with all the USB set to "n" and still couldn't S2D.
>
> Do you mean S2R?  I thought the bug is about S3?

Re: Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

[Jeff Chua]

On Fri, Feb 14, 2014 at 9:57 PM, Takashi Iwai <tiwai@suse.de> wrote:
> The other possible change in hda_intel.c is the enablement of runtime
> PM for Panther Point.  But it's been working for other chips, so
> wondering why it hits anything.  In anyway, please give the full
> Oops messages not only the stack trace.

> Any difference in the sound hardware, i.e. PCI controller and codec
> chips?

# X230 reported the sound card as:
00:1b.0 Audio device: Intel Corporation 7 Series/C210 Series Chipset
Family High Definition Audio Controller (rev 04)
== HDA Intel PCH, ALC269VC Analog

# X240 reported the sound card as:
00:1b.0 Audio device: Intel Corporation Lynx Point-LP HD Audio
Controller (rev 04)
==  HDA Intel PCH, ALC292 Analog

Now I managed to make suspend-to-ram work by using sound as module
instead of build-in.

Here's the difference ...

# bad
CONFIG_SND_HDA_CODEC_HDMI =y
CONFIG_SND_HDA_INTEL=y
CONFIG_SND_HDA_INPUT_BEEP=y
CONFIG_SND_HDA_CODEC_HDMI=y
CONFIG_SND_HDA_GENERIC=y


# good
CONFIG_SND_HDA_CODEC_HDMI =m
CONFIG_SND_HDA_INTEL=m
CONFIG_SND_HDA_INPUT_BEEP=m
CONFIG_SND_HDA_CODEC_HDMI=m
CONFIG_SND_HDA_GENERIC=m


Strange?

Jeff

Re: Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

[Steven Noonan]

On Fri, Feb 14, 2014 at 11:01 AM, Jeff Chua <jeff.chua.linux@gmail.com> wrote:
> On Fri, Feb 14, 2014 at 9:57 PM, Takashi Iwai <tiwai@suse.de> wrote:
>> The other possible change in hda_intel.c is the enablement of runtime
>> PM for Panther Point.  But it's been working for other chips, so
>> wondering why it hits anything.  In anyway, please give the full
>> Oops messages not only the stack trace.
>
>> Any difference in the sound hardware, i.e. PCI controller and codec
>> chips?
>
> # X230 reported the sound card as:
> 00:1b.0 Audio device: Intel Corporation 7 Series/C210 Series Chipset
> Family High Definition Audio Controller (rev 04)
> == HDA Intel PCH, ALC269VC Analog
>
> # X240 reported the sound card as:
> 00:1b.0 Audio device: Intel Corporation Lynx Point-LP HD Audio
> Controller (rev 04)
> ==  HDA Intel PCH, ALC292 Analog
>
> Now I managed to make suspend-to-ram work by using sound as module
> instead of build-in.
>
> Here's the difference ...
>
> # bad
> CONFIG_SND_HDA_CODEC_HDMI =y
> CONFIG_SND_HDA_INTEL=y
> CONFIG_SND_HDA_INPUT_BEEP=y
> CONFIG_SND_HDA_CODEC_HDMI=y
> CONFIG_SND_HDA_GENERIC=y
>
>
> # good
> CONFIG_SND_HDA_CODEC_HDMI =m
> CONFIG_SND_HDA_INTEL=m
> CONFIG_SND_HDA_INPUT_BEEP=m
> CONFIG_SND_HDA_CODEC_HDMI=m
> CONFIG_SND_HDA_GENERIC=m
>
>
> Strange?
>
> Jeff

Of those modules, which are loaded? If you load all of them and then
try to suspend, does it still work?

Re: Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

[Takashi Iwai]

At Sat, 15 Feb 2014 03:01:24 +0800,
Jeff Chua wrote:
> 
> On Fri, Feb 14, 2014 at 9:57 PM, Takashi Iwai <tiwai@suse.de> wrote:
> > The other possible change in hda_intel.c is the enablement of runtime
> > PM for Panther Point.  But it's been working for other chips, so
> > wondering why it hits anything.  In anyway, please give the full
> > Oops messages not only the stack trace.
> 
> > Any difference in the sound hardware, i.e. PCI controller and codec
> > chips?
> 
> # X230 reported the sound card as:
> 00:1b.0 Audio device: Intel Corporation 7 Series/C210 Series Chipset
> Family High Definition Audio Controller (rev 04)
> == HDA Intel PCH, ALC269VC Analog
> 
> # X240 reported the sound card as:
> 00:1b.0 Audio device: Intel Corporation Lynx Point-LP HD Audio
> Controller (rev 04)
> ==  HDA Intel PCH, ALC292 Analog
> 
> Now I managed to make suspend-to-ram work by using sound as module
> instead of build-in.
> 
> Here's the difference ...
> 
> # bad
> CONFIG_SND_HDA_CODEC_HDMI =y
> CONFIG_SND_HDA_INTEL=y
> CONFIG_SND_HDA_INPUT_BEEP=y
> CONFIG_SND_HDA_CODEC_HDMI=y
> CONFIG_SND_HDA_GENERIC=y
> 
> 
> # good
> CONFIG_SND_HDA_CODEC_HDMI =m
> CONFIG_SND_HDA_INTEL=m
> CONFIG_SND_HDA_INPUT_BEEP=m
> CONFIG_SND_HDA_CODEC_HDMI=m
> CONFIG_SND_HDA_GENERIC=m

It might be the remaining bugs of modularization in 3.14-rc2.
A few patches are found in for-linus branch of sound git tree, which
are included in Today's pull request.  Could you give it a try?

  git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-linus


Takashi

Re: Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

[Jeff Chua]

On Sat, Feb 15, 2014 at 4:07 AM, Takashi Iwai <tiwai@suse.de> wrote:

>> # bad
>> CONFIG_SND_HDA_CODEC_HDMI =y
>> CONFIG_SND_HDA_INTEL=y
>> CONFIG_SND_HDA_INPUT_BEEP=y
 CONFIG_SND_HDA_GENERIC=m
>
> It might be the remaining bugs of modularization in 3.14-rc2.
> A few patches are found in for-linus branch of sound git tree, which
> are included in Today's pull request.  Could you give it a try?

Pulled, but still the same. Modularized works fine -- even the modules
remains, s2r works. But setting to "Yes" ... won't suspend. I don't
kow how to capture those errors above the screens :(

Any suggestion on how to debug this? bisect? Ted, does your T540p work
with CONFIG_SND_HDA_INTEL=y instead of "m" ?

Thanks,
Jeff

Re: Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

[Theodore Ts'o]

On Tue, Feb 18, 2014 at 01:54:40AM +0800, Jeff Chua wrote:
> Any suggestion on how to debug this? bisect? Ted, does your T540p work
> with CONFIG_SND_HDA_INTEL=y instead of "m" ?

I can give this a try on my next kernel rebuild.

BTW, I am noticing some other suspend-to-ram wierdnesses.  In
particular, in about 1 in 10 to 1 in 20 suspend, the led lights on the
ethernet port are stuck on after the suspend, which I suspect means
we're not shutting down the peripherals all the way, and thus wasting
battery while the laptop is suspended.

Also, I am using a password to secure my HDD, and in most cases, the
HDD is left powered on so I can still access the HDD.  However, about
10% of the time, the HDD seems to get completely powered down, such
that it needs to have the password sent again to unlock the drive.
Since I am using the BIOS to send the password to the HDD, it means I
have to force a reboot in order to regain access to the drive.

So this is either a S2R bug in that we're not powering down the HDD
sufficiently to maximize power savings most of the time, or that we
need to be able to reauthenticate the HDD to unlock it after a
suspend/resume cycle --- something which it sounds like Linux doesn't
support all that well.  (I only recently started using HDD/SSD
passwords because I now have devices with FDE, and I've been trying to
secure my computing environment as much as possible.)

       	  	    		   	- Ted

Re: Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

[Theodore Ts'o]

On Mon, Feb 17, 2014 at 02:54:32PM -0500, Theodore Ts'o wrote:
> On Tue, Feb 18, 2014 at 01:54:40AM +0800, Jeff Chua wrote:
> > Any suggestion on how to debug this? bisect? Ted, does your T540p work
> > with CONFIG_SND_HDA_INTEL=y instead of "m" ?
> 
> I can give this a try on my next kernel rebuild.

I can confirm that suspend-to-ram hangs on my T540p if I build with
CONFIG_SND_HDA_INTEL=y.  I ran the test using v3.14-rc3.

						- Ted

Re: Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

[Takashi Iwai]

At Tue, 18 Feb 2014 14:06:55 -0500,
Theodore Ts'o wrote:
> 
> On Mon, Feb 17, 2014 at 02:54:32PM -0500, Theodore Ts'o wrote:
> > On Tue, Feb 18, 2014 at 01:54:40AM +0800, Jeff Chua wrote:
> > > Any suggestion on how to debug this? bisect? Ted, does your T540p work
> > > with CONFIG_SND_HDA_INTEL=y instead of "m" ?
> > 
> > I can give this a try on my next kernel rebuild.
> 
> I can confirm that suspend-to-ram hangs on my T540p if I build with
> CONFIG_SND_HDA_INTEL=y.  I ran the test using v3.14-rc3.

I checked CONFIG_SND_HDA_INTEL=y on my HP laptop with Haswell, but it
worked fine.  Could you give config?


Takashi

Re: Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

[Theodore Ts'o]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

On Tue, Feb 18, 2014 at 09:28:02PM +0100, Takashi Iwai wrote:
> 
> I checked CONFIG_SND_HDA_INTEL=y on my HP laptop with Haswell, but it
> worked fine.  Could you give config?

I don't have that config any more.  But I started with my the 3.14-rc3
config, turned off changed CONFIG_SND_HDA_INTEL to be =y, and then ran
"make oldconfig ; make deb-pkg".  See attached....

						- Ted


[-- Attachment #2: v3.14-rc3-config.gz --]
[-- Type: application/octet-stream, Size: 28392 bytes --]

Re: Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

[Jeff Chua]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Here's my .config  ...


On Wed, Feb 19, 2014 at 5:32 AM, Theodore Ts'o <tytso@mit.edu> wrote:
> On Tue, Feb 18, 2014 at 09:28:02PM +0100, Takashi Iwai wrote:
>>
>> I checked CONFIG_SND_HDA_INTEL=y on my HP laptop with Haswell, but it
>> worked fine.  Could you give config?
>
> I don't have that config any more.  But I started with my the 3.14-rc3
> config, turned off changed CONFIG_SND_HDA_INTEL to be =y, and then ran
> "make oldconfig ; make deb-pkg".  See attached....
>
>                                                 - Ted
>

[-- Attachment #2: config.gz --]
[-- Type: application/x-gzip, Size: 22140 bytes --]

Re: Lenovo X240 (haswell) suspend-to-ram hangs on 3-14.0-rc2

[Takashi Iwai]

At Wed, 19 Feb 2014 10:01:56 +0800,
Jeff Chua wrote:
> 
> Here's my .config  ...

I still couldn't reproduce the problem on my laptop, so I wonder
whether it may be really specific to Thinkpad.  If so, could you check
whether the patch below has any influence?


thanks,

Takashi

> On Wed, Feb 19, 2014 at 5:32 AM, Theodore Ts'o <tytso@mit.edu> wrote:
> > On Tue, Feb 18, 2014 at 09:28:02PM +0100, Takashi Iwai wrote:
> >>
> >> I checked CONFIG_SND_HDA_INTEL=y on my HP laptop with Haswell, but it
> >> worked fine.  Could you give config?
> >
> > I don't have that config any more.  But I started with my the 3.14-rc3
> > config, turned off changed CONFIG_SND_HDA_INTEL to be =y, and then ran
> > "make oldconfig ; make deb-pkg".  See attached....

---
diff --git a/sound/pci/hda/thinkpad_helper.c b/sound/pci/hda/thinkpad_helper.c
index 8fe3b8c18ed4..16c20f7c6166 100644
--- a/sound/pci/hda/thinkpad_helper.c
+++ b/sound/pci/hda/thinkpad_helper.c
@@ -2,7 +2,7 @@
  * to be included from codec driver
  */
 
-#if IS_ENABLED(CONFIG_THINKPAD_ACPI)
+#if 0 // IS_ENABLED(CONFIG_THINKPAD_ACPI)
 
 #include <linux/acpi.h>
 #include <linux/thinkpad_acpi.h>