From: Roland Dreier <rolandd@cisco.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Linus Torvalds <torvalds@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] missing include in infiniband
Date: Sat, 29 Oct 2005 07:08:25 -0700 [thread overview]
Message-ID: <52acgspg9y.fsf@cisco.com> (raw)
In-Reply-To: <20051029054603.GA7992@ftp.linux.org.uk> (Al Viro's message of "Sat, 29 Oct 2005 06:46:03 +0100")
> use of IS_ERR/PTR_ERR in infiniband/core/agent.c, without
> a portable chain of includes pulling err.h (breaks on a bunch of
> platforms).
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Looks good to me:
Acked-by: Roland Dreier <rolandd@cisco.com>
I guess I still need to a few more cross-compilers to me collection --
none of i386, x86_64, ppc64, ia64, sparc64 or ppc caught this :(.
- R.
prev parent reply other threads:[~2005-10-29 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-29 5:46 [PATCH] missing include in infiniband Al Viro
2005-10-29 14:08 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52acgspg9y.fsf@cisco.com \
--to=rolandd@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox