* [PATCH] missing include in infiniband
@ 2005-10-29 5:46 Al Viro
2005-10-29 14:08 ` Roland Dreier
0 siblings, 1 reply; 2+ messages in thread
From: Al Viro @ 2005-10-29 5:46 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Roland Dreier, linux-kernel
use of IS_ERR/PTR_ERR in infiniband/core/agent.c, without
a portable chain of includes pulling err.h (breaks on a bunch of
platforms).
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
----
diff -urN RC14-base/drivers/infiniband/core/agent.h current/drivers/infiniband/core/agent.h
--- RC14-base/drivers/infiniband/core/agent.h 2005-10-28 22:35:58.000000000 -0400
+++ current/drivers/infiniband/core/agent.h 2005-10-29 01:25:34.000000000 -0400
@@ -39,6 +39,7 @@
#ifndef __AGENT_H_
#define __AGENT_H_
+#include <linux/err.h>
#include <rdma/ib_mad.h>
extern int ib_agent_port_open(struct ib_device *device, int port_num);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] missing include in infiniband
2005-10-29 5:46 [PATCH] missing include in infiniband Al Viro
@ 2005-10-29 14:08 ` Roland Dreier
0 siblings, 0 replies; 2+ messages in thread
From: Roland Dreier @ 2005-10-29 14:08 UTC (permalink / raw)
To: Al Viro; +Cc: Linus Torvalds, linux-kernel
> use of IS_ERR/PTR_ERR in infiniband/core/agent.c, without
> a portable chain of includes pulling err.h (breaks on a bunch of
> platforms).
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Looks good to me:
Acked-by: Roland Dreier <rolandd@cisco.com>
I guess I still need to a few more cross-compilers to me collection --
none of i386, x86_64, ppc64, ia64, sparc64 or ppc caught this :(.
- R.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-10-29 14:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-29 5:46 [PATCH] missing include in infiniband Al Viro
2005-10-29 14:08 ` Roland Dreier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox